PAINTROID-799: Fix opacity regression after zoom and improve semi-transparent color swatch rendering#149
Open
DevAnuragT wants to merge 3 commits intoCatrobat:developfrom
Open
Conversation
Author
|
I couldn't comment on Jira under this issue, so I thought I should open a PR directly for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short Description
This PR fixes PAINTROID-799 by resolving opacity darkening after zoom gestures and improving semi-transparent color preview rendering in the toolbar swatch.
Jira ticket: PAINTROID-799
Root Cause
After a zoom interaction, an unintended paint-end commit could still be triggered.
This affected the latest active stroke, which explains why only the most recently added semi-transparent stroke got darker.
New Features and Enhancements
Refactorings and Bug Fixes
Validation
flutter analyzepasses on this branch.test/integration/brush_tool_test.dartVideo Proof
paintroid_opacity.mp4
Checklist
Your checklist for this pull request
Please review the contributing guidelines and wiki pages of this repository.