Conversation
Skip weight model fitting when the outcome has no variation (all 0s or 1s), storing None as a sentinel and assigning a weight of 1 — the correct value when treatment is structurally determined. Guards cense/visit prediction blocks against None models in _weight_predict.
ryan-odea
approved these changes
Mar 2, 2026
Member
ryan-odea
left a comment
ryan-odea
left a comment
There was a problem hiding this comment.
This looks good! I've added a commit to hopefully cause readthedocs to recover version information from the toml tag (I think the issue was both that it would install the package from pypi)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firstly a small apology - I duffed a commit onto main without it being in a PR (was just a typo in the README; amended SEQTaRget -> pySEQTarget in 2 places).
This,
the last two to try and match what I did in the R package.