Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 14, 2025

Four test assertions were checking for meta["renderer"] == "citeproc-py" but the implementation returns "citeproc", causing test failures.

Changes

  • Fixed assertions in test_render_bibliography_vancouver_style (line 69)
  • Fixed assertions in test_render_bibliography_chicago_style (line 137)
  • Fixed assertions in test_render_bibliography_empty_citations (line 201)
  • Fixed assertions in test_render_bibliography_with_locale (line 227)

All tests now align with the actual return value from render_bibliography_to_strings():

# Implementation returns:
{"renderer": "citeproc", "style": style, "locale": locale}

# Tests now correctly assert:
assert meta["renderer"] == "citeproc"

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: dosumis <112839+dosumis@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Dec 14, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • astral.sh
    • Triggering command: /usr/bin/curl curl -LsSf REDACTED (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Address feedback from PR #9 on dependency and testing improvements Fix renderer assertion mismatches in test_rendering.py Dec 14, 2025
Copilot AI requested a review from dosumis December 14, 2025 15:14
Base automatically changed from ID_lookup_fix to main December 14, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants