[ENG-10217] Files cannot be moved from a Component to a Parent Project #876
+36
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
brianjgeiger
previously approved these changes
Feb 10, 2026
Contributor
brianjgeiger
left a comment
brianjgeiger
left a comment
There was a problem hiding this comment.
One improvement which we can do now or put in a separate ticket.
| const parentId = node.relationships.parent?.data?.id; | ||
| if (!parentId) return [node]; | ||
|
|
||
| const ancestors = this.getAllAncestors(allNodes, parentId); |
Contributor
There was a problem hiding this comment.
This is an API heavy way to do this. To get all nodes in a hierarchy, you can just /v2/nodes/?filter[root]={project.root}. You might have to sort them in JS, but it will make far fewer calls.
If need be, we can make a technical improvement ticket to fix this that isn't a hotfix, but it'd be nice to not have this kind of thing be in the codebase for too long.
Contributor
There was a problem hiding this comment.
Talked on Slack, and this won't be necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Screenshot(s)