[ENG-8515] - Add management command to manual archive#11361
Open
Vlad0n20 wants to merge 3 commits intoCenterForOpenScience:feature/pbs-25-25from
Open
[ENG-8515] - Add management command to manual archive#11361Vlad0n20 wants to merge 3 commits intoCenterForOpenScience:feature/pbs-25-25from
Vlad0n20 wants to merge 3 commits intoCenterForOpenScience:feature/pbs-25-25from
Conversation
Collaborator
|
@Vlad0n20 Could you rebase this onto the latest |
d4b7a7c to
ec8aaaf
Compare
Contributor
Author
Collaborator
|
@Vlad0n20 There is a merge conflict. Also, could you update the PR description to include a bit more info for the fix (e.g. the purpose of the two management commands) so that reviewers have a better idea about the fix? Thanks. |
77bd450 to
a9ee0c5
Compare
bc6ab8c to
657e015
Compare
Collaborator
|
Sorry, two more merge conflicts. @Vlad0n20 |
657e015 to
af6ab82
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Changes
process_manual_restart_approvals checks all manually restarted registrations and determines if
they're ready for approval
Added was_manually_restarted() function that checks if a registration was manually restarted within the last 48
hours
Modified archive_success() to automatically schedule an approval check 5 minutes after successful archival
This ensures manually restarted registrations get back into the approval pipeline
When an admin uses the "Force Archive" feature, it now logs this action in AdminLogEntry
old flow:
new one:
QA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket
https://openscience.atlassian.net/browse/ENG-8515?atlOrigin=eyJpIjoiZjdmOTIyZTYxOGIxNDAzNjhhZmY5ZjliYzQzMjg4MzciLCJwIjoiaiJ9