[ENG-8491] Feature/eng 8491#11406
Open
Vlad0n20 wants to merge 3 commits intoCenterForOpenScience:feature/pbs-25-25from
Open
[ENG-8491] Feature/eng 8491#11406Vlad0n20 wants to merge 3 commits intoCenterForOpenScience:feature/pbs-25-25from
Vlad0n20 wants to merge 3 commits intoCenterForOpenScience:feature/pbs-25-25from
Conversation
Contributor
|
Looks great! |
Vlad0n20
changed the base branch from
feature/pbs-25-21
to
feature/pbs-25-25
Vlad0n20
force-pushed
the
feature/ENG-8491
branch
from
1b8c36d to
aa38bee
Compare
adlius
reviewed
Dec 29, 2025
Comment on lines
+24
to
+25
| class AddSystemTagForm(forms.Form): | ||
| system_tag_to_add = forms.CharField(label='system_tag_to_add', min_length=1, max_length=1024, required=True) |
Collaborator
There was a problem hiding this comment.
What is this? Does this belong to this ticket?
Contributor
Author
There was a problem hiding this comment.
I didn't add that. In git blame, I see that it was added on 12/02, and I created this PR last week.
Vlad0n20
force-pushed
the
feature/ENG-8491
branch
from
aa38bee to
21ed3c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Changes
QA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket
https://openscience.atlassian.net/browse/ENG-8491?atlOrigin=eyJpIjoiNDVmYWQ5ODk0OTJlNGE0Y2FjMDI4ZjNiYWI4NTNmNmEiLCJwIjoiaiJ9