[ENG-9820]: cleanup and delete dead ES2 code#11688
Open
ihorsokhanexoft wants to merge 18 commits intoCenterForOpenScience:feature/es2-consolidationfrom
Open
[ENG-9820]: cleanup and delete dead ES2 code#11688ihorsokhanexoft wants to merge 18 commits intoCenterForOpenScience:feature/es2-consolidationfrom
ihorsokhanexoft wants to merge 18 commits intoCenterForOpenScience:feature/es2-consolidationfrom
Conversation
Contributor
|
Clean, well-scoped deletion. One missed cleanup: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://openscience.atlassian.net/browse/ENG-9820
Purpose
After removing v1/v2 search endpoints, there is a lot of unused code that can be removed
Changes
Remove legacy code
IT IS HIGHLY RECOMMENDED TO REVIEW THIS PULL REQUEST COMMIT BY COMMIT