[ENG-11010] Registrations continue to get stuck archiving#11728
Open
antkryt wants to merge 1 commit intoCenterForOpenScience:feature/pbs-26-9from
Open
[ENG-11010] Registrations continue to get stuck archiving#11728antkryt wants to merge 1 commit intoCenterForOpenScience:feature/pbs-26-9from
antkryt wants to merge 1 commit intoCenterForOpenScience:feature/pbs-26-9from
Conversation
mkovalua
reviewed
May 8, 2026
| sentry.log_exception(archiver_state_exc) | ||
| raise archiver_state_exc | ||
| job_pk = kwargs.get('job_pk') | ||
| job = self.load_archive_job(job_pk, retry_if_missing=False, task_id=task_id, kwargs=kwargs) |
Contributor
There was a problem hiding this comment.
Just to clarify:
why should it be retry_if_missing=False but not somehow depend on max_retries and retry attempts left
Contributor
Author
There was a problem hiding this comment.
This function is running after the Celery task failure, so we just try to get archive job (it either available or not). General idea looks like this:
ArchiveTask tries to get the ArchiveJob with retries (currently ArchiveTasks are retried ONLY if ArchiveJob is missing, because autoretry_for is None) -> after max retries we raise error, so ArchiveTask.on_failure is called and try to get ArchiveJob to create exception context later
mkovalua
approved these changes
May 8, 2026
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Purpose
Retry if archive job is missing
Changes
Side Effects
QE Notes
CE Notes
Documentation