Gamma support #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucaGemma87
commented
Dec 21, 2015
LucaGemma87
commented
- Debugging and checking the joint state publisher.
- Hardware interface
now all seems work well !
modified: README.md deleted: config/force_torque_sensor_control.yaml modified: launch/display_simulation.launch modified: model/ft_sensor.gazebo.xacro modified: model/ft_sensor.urdf.xacro config/ launch/control_sensor_simulation.launch model/ft_sensor.trasmission.xacro
README.md
Outdated
LucaGemma87
force-pushed
the
gamma-support
branch
from
55069f4 to
5441e9e
Compare
only warning message to be solved
Only warning message to resolve
Deleted unused files.
add ft_simulation_display.launch
add ft_simulation_display.launch
|
|
||
| 1) on first terminal for nano17 ft sensor type: | ||
|
|
||
| roslaunch force_torque_sensor ft_simulation_display.launch use_gamma:=false |
Contributor
There was a problem hiding this comment.
Is there a way to pass a string instead of a true/false arg?
Would be nice to have something like:
roslaunch force_torque_sensor ft_simulation_display.launch use_model:=gamma
Contributor
|
Review done. Let me know about the suggestion above... and thanks! |
Contributor
|
Thanks @LucaGemma87 . One last thing before merging, you moved this file from the model to the robot folder: Is there a reason for that? If not, I'd prefer that files implementing macros remain in the model folder, and their uses in the robot folder. Other than that, ok for the rest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.