Skip to content

Use the solution from 38#43

Open
jacomago wants to merge 4 commits intomasterfrom
38-sky
Open

Use the solution from 38#43
jacomago wants to merge 4 commits intomasterfrom
38-sky

Conversation

@jacomago
Copy link
Contributor

See #38 for discussion

@sonarqubecloud
Copy link

Copy link

@anderslindho anderslindho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't #38 then be merged instead/first?

@simon-ess
Copy link

@anderslindho - this contains the code from #38.

@anderslindho
Copy link

@anderslindho - this contains the code from #38.

I can see that @simon-ess, my point is that we would lose related discussions if this is merged and #38 is closed.

@jacomago
Copy link
Contributor Author

@anderslindho - this contains the code from #38.

I can see that @simon-ess, my point is that we would lose related discussions if this is merged and #38 is closed.

I don't have access to the branch for #38 so I can't work on top of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants