Open
Conversation
progressive and local methods used regex + json.loads to extract bare JSON arrays from responses. Models that wrap output in objects or markdown fences got silently dropped. Switch to parse_comments_from_response() which already handles all these formats (and was already used by zero_shot). Closes ChicagoHAI#22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
progressive and local methods parsed responses with
re.search(r"\[.*\]") + json.loads(), which only works for bare JSON arrays. Models like GLM-5 and Kimi that wrap output in{"comments": [...]}or markdown fences got silently dropped → 0 comments.Switched all 3 call sites to
parse_comments_from_response(), which already handles these formats and was already used by zero_shot.Closes #22