You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Tested in debian12 with nala installed works as expected.
Tested other modified scripts in arch works as expected.
Additional Information
Warning
#440#442#443 are implemented after this PR. Check those PRs with mine and decide which one to merge
Caution
The implementation of #440 is wrong
Replacing apt-get with apt is not recommended when using in scripts.
Only if we switch nala and apt-get places in common script it will check for nala first if found it will choose nala as the package manager.
If not it will check for apt-get. On his implementation it will use apt itself as it checks for apt first.
Checklist
My code adheres to the coding and style guidelines of the project.
I have performed a self-review of my own code.
I have commented my code, particularly in hard-to-understand areas.
My changes generate no errors/warnings/merge conflicts.
And again you're literally just putting my changes into this one @jeevithakannan2 as seen with the commits before 100fc58 this one was incomplete... You shouldn't lie..
#440#442#443 are implemented after this PR with half of the my changes only. It is not completely finished. Check those two PRs with mine and decide which one to merge
Go on and spam in other people PR's after copying them
Did not copy you, 2. I'm competing with this PR, 3. Your PR was incomplete when I had made the other PRs, 4. The blatant lying is ridiculous when we have a commit that explains everything... Compare the dates of the creation if you want: 100fc58 before the changes: 61cddeb
Go on and spam in other people PR's after copying them
1. Did not copy you, 2. I'm competing with this PR, 3. Your PR was incomplete when I had made the other PRs, 4. The blatant lying is ridiculous when we have a commit that explains everything... Compare the dates of the creation if you want: [100fc58](https://github.com/ChrisTitusTech/linutil/commit/100fc58daa91b127187497f0061922786747db0d) before the changes: [61cddeb](https://github.com/ChrisTitusTech/linutil/commit/61cddeb2566f0c874c15428986381832203f3591)
If you didn't copy then how come I copied you? 2. You could have mentioned some places are missing rather than creating 3 extra PRs 3. I didn't lie I don't remember saying I have covered all the scripts. 4. You had some places not covered before this commit 4404169 So that means you were lying that you covered all the scripts??
Go on and spam in other people PR's after copying them
1. Did not copy you, 2. I'm competing with this PR, 3. Your PR was incomplete when I had made the other PRs, 4. The blatant lying is ridiculous when we have a commit that explains everything... Compare the dates of the creation if you want: [100fc58](https://github.com/ChrisTitusTech/linutil/commit/100fc58daa91b127187497f0061922786747db0d) before the changes: [61cddeb](https://github.com/ChrisTitusTech/linutil/commit/61cddeb2566f0c874c15428986381832203f3591)
1. If you didn't copy then how come I copied you? 2. You could have mentioned some places are missing rather than creating 3 extra PRs 3. I didn't lie I don't remember saying I have covered all the scripts. 4. You had some places not covered before this commit [4404169](https://github.com/ChrisTitusTech/linutil/commit/4404169e82ff774aa9d39c9f2c961e6900723c0a) So that means you were lying that you covered all the scripts??
No, not exactly, I had missed those but my original implementation was correct, and BTW you shouldn't blatantly take my semi-complete fix and put it into a half baked PR.. And then start an argument over it after taking everything that was in my PR that fixed everything in this.. Here are the commits before & after you blatantly lied: before: 61cddeb after: 100fc58
You're still missing some stuff that is correctly implemented in my 3 PRs, and you're modifying the aurhelpers when that wont be needed with #382 . Lets stop arguing over this nonsense... Just close this as its incomplete. @jeevithakannan2
I don't understand what you're calling incorrect in my PR and correct in yours??
"Replacing apt-get with apt is not recommended when using in scripts." - apt overall has more features than apt-get. apt-get is "deprecated" in some distros. Why do you think it's not recommended? I recommend using apt.
"On his implementation it will use apt itself as it checks for apt first." - And what's wrong with this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Title
Use nala , replace hardcoded package managers, add missing checkEnv and checkEscalationTool, implement posix recommended way of using variables
Type of Change
Description
PACKAGERvariablecheckEnvin numlock for consistency among scriptscheckEscalationToolin monitor control for consistency among scriptsgaming-setup.sh#380Issue related to PR
Testing
Additional Information
Warning
#440 #442 #443 are implemented after this PR. Check those PRs with mine and decide which one to merge
Caution
The implementation of #440 is wrong
Replacing apt-get with apt is not recommended when using in scripts.
Only if we switch nala and apt-get places in common script it will check for nala first if found it will choose nala as the package manager.
If not it will check for apt-get. On his implementation it will use apt itself as it checks for apt first.
Checklist