Skip to content

Comments

Quote the remaining variables#454

Merged
ChrisTitusTech merged 2 commits intomainfrom
unknown repository
Sep 19, 2024
Merged

Quote the remaining variables#454
ChrisTitusTech merged 2 commits intomainfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Sep 18, 2024

Type of Change

  • Bug fix (potential)
  • Refactoring

Description

Quoting variables is a good practice in shell scripting / bash scripting

NOTICE: Gaming-setup was intentionally left out due to an amazing rewrite in #380 and the aur helper reverts were also left out due to another amazing rewrite in #382

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • My changes generate no errors/warnings/merge conflicts.

@ghost
Copy link
Author

ghost commented Sep 18, 2024

ill fix this for you Chris ❤️

@ghost
Copy link
Author

ghost commented Sep 18, 2024

image
nvm.. ill just close this. "Start over"

@ghost ghost closed this Sep 18, 2024
@ghost ghost deleted the quotevariables branch September 18, 2024 19:12
@koibtw koibtw mentioned this pull request Sep 18, 2024
5 tasks
@ghost ghost restored the quotevariables branch September 18, 2024 21:19
@ghost ghost reopened this Sep 18, 2024
@ChrisTitusTech ChrisTitusTech merged commit 0d4f0a8 into ChrisTitusTech:main Sep 19, 2024
@ghost ghost deleted the quotevariables branch September 19, 2024 10:36
@cartercanedy cartercanedy mentioned this pull request Sep 30, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants