repair many ref error: path issue.#353
Open
eaglexmw-gmail wants to merge 1 commit intoChristopherChudzicki:masterfrom
Open
repair many ref error: path issue.#353eaglexmw-gmail wants to merge 1 commit intoChristopherChudzicki:masterfrom
eaglexmw-gmail wants to merge 1 commit intoChristopherChudzicki:masterfrom
Conversation
Owner
|
Hi @eaglexmw-gmail Thanks for opening a PR. Those imports are not broken since math3d uses Admittedly, this is not really a great way to implement absolute imports... I think for the rewrite of math3d (in the works) I'll use something like craco to patch create react app to have Line 5 in e2165ee |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix bug: import module from invalid path.
all compile/test ok.