Skip to content

[IOS-XR] Fix show l2vpn bridge-domain detail : Parses variations in the EVI field format correctly#907

Open
Kani999 wants to merge 1 commit intoCiscoTestAutomation:mainfrom
Kani999:fix_evi_show_l2vpn_bridge_domain_detail
Open

[IOS-XR] Fix show l2vpn bridge-domain detail : Parses variations in the EVI field format correctly#907
Kani999 wants to merge 1 commit intoCiscoTestAutomation:mainfrom
Kani999:fix_evi_show_l2vpn_bridge_domain_detail

Conversation

@Kani999
Copy link
Copy Markdown
Contributor

@Kani999 Kani999 commented Oct 29, 2024 •
edited
Loading

  • Modified p63 regex in show_l2vpn.py to support optional suffix (e.g., "(SRv6)") for EVI values
  • Updated golden9_expected.py to reflect new test output for EVI field
  • Adjusted URL in github_parser.json for the updated line reference

These changes enhance the parser's compatibility with new formats in ShowL2vpnBridgeDomainDetail.

Description

The ShowL2vpnBridgeDomainDetail parser for IOS-XR devices was not handling some variations in the EVI field format correctly, resulting in parsing errors or missed data. Specifically, when the evi field includes additional suffix information (e.g., (SRv6)), the parser could not match this pattern and failed to extract the EVI value.

Motivation and Context

  • Support optional suffix (e.g., "(SRv6)") for EVI values

Closes #906

Checklist:

  • I have updated the changelog.
  • I have updated the documentation (If applicable).
  • I have added tests to cover my changes (If applicable).
  • All new and existing tests passed.
  • All new code passed compilation.

@Kani999 Kani999 requested a review from a team as a code owner October 29, 2024 09:54
@Kani999 Kani999 requested review from lsheikal and omehrabi October 29, 2024 09:54
@Kani999 Kani999 force-pushed the fix_evi_show_l2vpn_bridge_domain_detail branch from 1fae532 to afd0682 Compare October 29, 2024 10:00
@Kani999

This comment was marked as resolved.

Sign in to view
@Kani999 Kani999 force-pushed the fix_evi_show_l2vpn_bridge_domain_detail branch from afd0682 to 9aa193c Compare December 2, 2024 12:38
@Kani999
Copy link
Copy Markdown
Contributor Author

Kani999 commented May 26, 2025

Hi there! 👋
If anyone revisits this PR in the future:
Thank you for taking the time to look at this contribution. If you have any questions about the changes, need further clarification, or would like additional context, please feel free to tag me @Kani999. I appreciate your review and feedback!

Best regards,
Kani999

@Kani999 Kani999 force-pushed the fix_evi_show_l2vpn_bridge_domain_detail branch 2 times, most recently from 3c4e60a to 07af294 Compare January 20, 2026 11:08
@Kani999
Copy link
Copy Markdown
Contributor Author

Kani999 commented Jan 20, 2026

Hi team,

This PR was opened on Oct 29, 2024, and it's been over a year now. The build is failing in Python 3.9 job due to "Error: Version 3.9 with arch x64 not found" in actions/setup-python@v1 (available: 3.10+), which this PR doesn't affect.

Could you please review and merge it when possible? I'd love to install the official version soon.

Thanks!

@Kani999 Kani999 force-pushed the fix_evi_show_l2vpn_bridge_domain_detail branch from 2ee3c26 to 8670db6 Compare March 27, 2026 05:15
@Kani999
Fix: update EVI regex and test output in show_l2vpn_bridge_domain_det…
ae0e069 
…ail parser

- Modified `p63` regex in `show_l2vpn.py` to support optional suffix (e.g., "(SRv6)") for EVI values
- Updated `golden9_expected.py` to reflect new test output for EVI field
- Adjusted URL in `github_parser.json` for the updated line reference

These changes enhance the parser's compatibility with new formats in `ShowL2vpnBridgeDomainDetail`.
@Kani999 Kani999 force-pushed the fix_evi_show_l2vpn_bridge_domain_detail branch from 8670db6 to ae0e069 Compare March 27, 2026 05:21
@Kani999 Kani999 mentioned this pull request Mar 27, 2026
Open
@Kani999
Copy link
Copy Markdown
Contributor Author

Kani999 commented Mar 27, 2026

Verified: current genie/main still fails — this PR is needed

Tested against genie/main at commit 285024fb050cdbe54ee5c8490df5068661a41061 (release v26.2).

Test results

The golden9 test on main already contains evi: 1002 (SRv6) in the raw output, but main's p63 regex (^evi: +(?P<evi>\d+)$) cannot match the (SRv6) suffix — the EVI value is silently dropped.

Test This branch genie/main (old parser)
golden1–8 PASS PASS
golden9 (with evi: 1002 (SRv6)) PASS FAIL
empty PASS PASS

Branch has been rebased on genie/main (285024fb0) and force-pushed.

PR checklist status

  • Changelog: changelog/undistributed/changelog_show_l2vpn_bridge_domain_detail_iosxr_20241029105539.rst
  • make json: updated (1 line number shift in github_parser.json)
  • All 10 tests pass on this branch
  • No regressions on existing tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lsheikal lsheikal Awaiting requested review from lsheikal lsheikal is a code owner automatically assigned from CiscoTestAutomation/pyats-genie-devs

@omehrabi omehrabi Awaiting requested review from omehrabi omehrabi is a code owner automatically assigned from CiscoTestAutomation/pyats-genie-devs

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[IOS-XR] Parsing Incompatibility for show l2vpn bridge-domain detail Command Output

1 participant

@Kani999