Add UpdateFlags injection#174
Open
naeem76 wants to merge 2 commits intoCitiesSkylinesMultiplayer:masterfrom
Open
Add UpdateFlags injection#174naeem76 wants to merge 2 commits intoCitiesSkylinesMultiplayer:masterfrom
naeem76 wants to merge 2 commits intoCitiesSkylinesMultiplayer:masterfrom
Conversation
kaenganxt
requested changes
Apr 15, 2020
Member
kaenganxt
left a comment
kaenganxt
left a comment
There was a problem hiding this comment.
Hi, thank you for your contribution and sorry for taking so long to respond.
Your code looks good to me!
The build is failing because it looks like you forgot to add the changes of your CSM.csproj
Please add them to this PR.
I'll also test it out tomorrow.
Author
|
No probs on the time, I did some more testing afterwards, and in extreme scenarios it is a bit desynced, because server and client are doing their own thing, probably need to cancel any client side actions for these. I tried using harmony to skip original method when client side, but not working great. I'll check later when i have more time! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for #101
I have just started looking into Cities modding, so apologies if there's any issue, I'm planning to contribute more if things go well.
Tested with 2 local instances of cities, and abandoned buildings were synced.