Fix client-side caching of PARTY_ENABLE prop#145
Merged
Conversation
- Cache in PropertyContainer instead of per-property
WaitingIdly
reviewed
Mar 17, 2026
Collaborator
There was a problem hiding this comment.
tested on a dev server with 2 accounts, creating a party didnt work correctly on the 1.12 branch, worked correctly here.
because if how this was changed, i dont think IPropertyListener needs to exist anymore. unless theres a compelling argument to keep it, seems simpler to just use Consumer.
WaitingIdly
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue introduced in v4.2.7 where any party-related functions would not work on the client-side in a dedicated server. Players would seemingly be unable to create parties because the client would be unable to
getParty()due to the cached property not being updated.(Listeners are now attached to
PropertyContainerinstead ofIPropertyType; this was a mistake as different containers can have instances of the same property type.)