Fix ore-dict based matching in PartyInventory#149
Merged
Conversation
- Packed ids can't handle wildcard meta This reverts commit 784a16f.
WaitingIdly
approved these changes
Apr 2, 2026
WaitingIdly
requested changes
Apr 2, 2026
WaitingIdly
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PartyInventorywas not actually accounting for retrieval tasks that had ore-dict specified, just the base stack. This checks the hash of all stacks in the ore-dict when necessary to get the corresponding party's matching stacks.Switched to usingRecipeItemHelper#pack()for hashing.Fixes #147.