Skip to content

Dedupe updateLayout on first open #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rsslone wants to merge 1 commit into
base: cleanroom
Choose a base branch
from
Open

Dedupe updateLayout on first open #203

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions src/main/java/mezz/jei/gui/recipes/RecipesGui.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ public class RecipesGui extends GuiScreen implements IRecipesGui, IShowsRecipeFo
private int guiTop;

private boolean init = false;
private boolean openingGui = false;

public RecipesGui(IRecipeRegistry recipeRegistry, IngredientRegistry ingredientRegistry) {
this.logic = new RecipeGuiLogic(recipeRegistry, this, ingredientRegistry);
Expand Down Expand Up @@ -477,17 +478,27 @@ public void close() {
public <V> void show(IFocus<V> focus) {
focus = Focus.check(focus);

if (logic.setFocus(focus)) {
open();
openingGui = true;
try {
if (logic.setFocus(focus)) {
open();
}
} finally {
openingGui = false;
Copy link
Copy Markdown

@jchung01 jchung01 May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this in a try-finally block?

Copy link
Copy Markdown
Contributor Author

@Rsslone Rsslone May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To ensure it always gets set back to false, is it actually a concern? I don't know.

}
}

@Override
public void showCategories(List<String> recipeCategoryUids) {
ErrorUtil.checkNotEmpty(recipeCategoryUids, "recipeCategoryUids");

if (logic.setCategoryFocus(recipeCategoryUids)) {
open();
openingGui = true;
try {
if (logic.setCategoryFocus(recipeCategoryUids)) {
open();
}
} finally {
openingGui = false;
Copy link
Copy Markdown

@jchung01 jchung01 May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this in a try-finally block?

Copy link
Copy Markdown
Contributor Author

@Rsslone Rsslone May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To ensure it always gets set back to false, is it actually a concern? I don't know.

}
}

Expand Down Expand Up @@ -658,7 +669,9 @@ private List<String> searchButtonTooltip() {

@Override
public void onStateChange() {
updateLayout();
if (!openingGui) {
updateLayout();
}
}

@Nullable
Expand Down