Skip to content

Optimize AnvilRecipe storage #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jchung01 wants to merge 3 commits into
base: cleanroom
Choose a base branch
from
Open

Optimize AnvilRecipe storage #208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
173bd67
Optimize AnvilRecipe storage
jchung01 May 13, 2026
f68e588
Fix typo
jchung01 May 13, 2026
03f8706
Further reduce AnvilRecipeWrapper memory usage
jchung01 May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/main/java/mezz/jei/plugins/vanilla/VanillaRecipeFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
package mezz.jei.plugins.vanilla;

import java.util.Collections;
import java.util.List;

import net.minecraft.item.ItemStack;

import com.google.common.base.Preconditions;
import com.google.common.collect.ImmutableList;
import mezz.jei.api.recipe.IRecipeWrapper;
import mezz.jei.api.recipe.IVanillaRecipeFactory;
import mezz.jei.plugins.vanilla.anvil.AnvilRecipeWrapper;
Expand All @@ -21,7 +21,7 @@ public IRecipeWrapper createAnvilRecipe(ItemStack leftInput, List<ItemStack> rig
ErrorUtil.checkNotEmpty(outputs, "outputs");
Preconditions.checkArgument(rightInputs.size() == outputs.size(), "Input and output sizes must match.");

return new AnvilRecipeWrapper(Collections.singletonList(leftInput), rightInputs, outputs);
return new AnvilRecipeWrapper(ImmutableList.of(leftInput), ImmutableList.copyOf(rightInputs), ImmutableList.copyOf(outputs));
}

@Override
Expand All @@ -32,7 +32,7 @@ public IRecipeWrapper createAnvilRecipe(List<ItemStack> leftInputs, List<ItemSta
Preconditions.checkArgument(leftInputs.size() == rightInputs.size(), "Both input sizes must match.");
Preconditions.checkArgument(rightInputs.size() == outputs.size(), "Input and output sizes must match.");

return new AnvilRecipeWrapper(leftInputs, rightInputs, outputs);
return new AnvilRecipeWrapper(ImmutableList.copyOf(leftInputs), ImmutableList.copyOf(rightInputs), ImmutableList.copyOf(outputs));
}

@Override
Expand Down
Loading