Add version bump option to publish workflow #748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a 'version_bump' input to the publish GitHub Actions workflow, allowing selection of patch, minor, or major version increments before prerelease generation. The script now applies the specified version bump to the base version before determining the next available prerelease version.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ariser
reviewed
Jan 8, 2026
.github/workflows/publish.yml
Outdated
Comment on lines
78
to
128
| # Apply version bump if requested | ||
| BUMP_TYPE="${{ github.event.inputs.version_bump || 'none' }}" | ||
| if [ "$BUMP_TYPE" != "none" ]; then | ||
| echo "Applying $BUMP_TYPE version bump to $BASE_VERSION" | ||
| # Split version into major.minor.patch | ||
| IFS='.' read -r MAJOR MINOR PATCH <<< "$BASE_VERSION" | ||
| case "$BUMP_TYPE" in | ||
| patch) | ||
| PATCH=$((PATCH + 1)) | ||
| ;; | ||
| minor) | ||
| MINOR=$((MINOR + 1)) | ||
| PATCH=0 | ||
| ;; | ||
| major) | ||
| MAJOR=$((MAJOR + 1)) | ||
| MINOR=0 | ||
| PATCH=0 | ||
| ;; | ||
| esac | ||
| BASE_VERSION="${MAJOR}.${MINOR}.${PATCH}" | ||
| echo "New base version after bump: $BASE_VERSION" | ||
| fi | ||
| # Find the next available prerelease number | ||
| PRERELEASE_NUM=0 | ||
| while true; do | ||
| TEST_VERSION="${BASE_VERSION}-${GITHUB_TAG}.${PRERELEASE_NUM}" | ||
| # Check if this version exists on npm | ||
| if npm view @clickhouse/click-ui@${TEST_VERSION} version 2>/dev/null; then | ||
| echo "Version ${TEST_VERSION} already exists, trying next number..." | ||
| PRERELEASE_NUM=$((PRERELEASE_NUM + 1)) | ||
| else | ||
| # Version doesn't exist, we can use it | ||
| NEW_VERSION="${TEST_VERSION}" | ||
| break | ||
| fi | ||
| # Safety limit to prevent infinite loops | ||
| if [ $PRERELEASE_NUM -gt 100 ]; then | ||
| echo "Error: Too many prerelease versions (>100)" | ||
| exit 1 | ||
| fi | ||
| done | ||
| echo "Generated prerelease version: $NEW_VERSION" | ||
| npm pkg set version=$NEW_VERSION --no-git-tag-version |
Collaborator
There was a problem hiding this comment.
can't we just npm version $BUMP_TYPE?
ariser
reviewed
Jan 8, 2026
.github/workflows/publish.yml
Outdated
| done | ||
| echo "Generated prerelease version: $NEW_VERSION" | ||
| npm pkg set version=$NEW_VERSION --no-git-tag-version |
Collaborator
There was a problem hiding this comment.
I think NEW_VERSION isn't always defined here
Streamlines the publish.yml workflow by removing the version_bump input, consolidating version/tag handling, and improving prerelease version generation. The workflow now auto-increments patch versions for prereleases, sets npm tags more consistently, and adds cleanup for failed releases. This reduces complexity and improves maintainability for both manual and release-triggered publishing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a 'version_bump' input to the publish GitHub Actions workflow, allowing selection of patch, minor, or major version increments before prerelease generation. The script now applies the specified version bump to the base version before determining the next available prerelease version.
There was also an issue with publishing the same beta version on the same version, so added a fix to move the count up so it won't break