fix: 🐛 minimal react 19 and rsc support #756
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
punkbit
force-pushed
the
fix/minimal-react-19-rsc-support
branch
from
af90b2a to
8dea336
Compare
🦋 Changeset detectedLatest commit: b23c72f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…act-19-rsc-support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
TLDR; Click-UI fails to install, run or build on major React-like libraries, e.g. HyperDX, Nextjs, Vitejs latest. The PR provides a minimal set of changes to unblock the team.
The current/latest versions of click-ui, such as https://www.npmjs.com/package/@clickhouse/click-ui/v/0.0.250, break on the latest of Nextjs, Vitejs, any React >= 19 or RSC enabled builds. To mitigate it, this initial PR provides the minimal setup required for it to work in such environments, e.g. when installing the package, it should run in dev and build processes. It does NOT try to modify, replace, introduce or change breaking changes. At the time of writing, the library requires a browser runtime, being client-only. Separately, there'll be other PR to address other related concerns and expand on this initial PR, e.g. none interactive components shall render server-side.
How?
Demo?
demo-cui-nextjs-latest-build-output.mp4
demo-cui-nextjs-v16-latest.mp4
demo-cui-vite-latest.mp4
demo-cui-nextjs-v16-latest.mp4