-
Notifications
You must be signed in to change notification settings - Fork 15
chore: 🤖 prefer single quotes #771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| @@ -4,12 +4,12 @@ const theme = { | |||
| sm: { | |||
| icon: { | |||
| size: { | |||
| height: "1rem", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be edited like this
You need to the style dictionary inorder to accomadate changes which we create using build-tokens
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vineethasok the linter and formatter process files in src/*.
What you're seeing here is the result of the computations provided by the linter and formatter of the team's choice!
Any file placed in the directories, which might or not exclusively generate in the context of the project, such as external sources, whether that be Figma, your text editor, or others, once stored in the project, will be processed accordingly. That's what a formatter and linter processes do: you set rules, and it computes them.
If any directories or files should be an exception, then that has to be declared.
But it seems unnecessary to point this out due to the generated files working in any of the preferred formats, which, at the moment, was decided by @hoorayimhelping request to be single-quote. Conversely, for double quotes, the linter would show a linter warning from now on, and every time the file is placed in the project.
Which once "lint:fix: is fixed into the rules chosen. So, this is not exactly a problem.
Why?
To accomodate request to use single quotes instead of double quotes.
How?
Preview?