feat: support metadata and resource config for version probe jobs#143
Open
ashishch432 wants to merge 1 commit intoClickHouse:mainfrom
Open
feat: support metadata and resource config for version probe jobs#143ashishch432 wants to merge 1 commit intoClickHouse:mainfrom
ashishch432 wants to merge 1 commit intoClickHouse:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
To support priortyclass, additional metadata support and a small resource footprint for jobs.
What
ClickHouseClusterSpecandKeeperClusterSpec.[]MetadataItemfor clean CRD compatibility).priorityClassNameandruntimeClassName(applied to both main pods and the probe Job).app.kubernetes.io/instance: <cluster-name>-version-probe. This prevents E2E tests, Services, or health checks from accidentally counting the probe as a real cluster member.Fixes #128. I did see #134 for job resources, but inheriting the full cluster resources may be much for a job.