feat(ser): tuple structs support for sql serializer#305
Open
marcin-ptaszynski wants to merge 1 commit intoClickHouse:mainfrom
Open
feat(ser): tuple structs support for sql serializer#305marcin-ptaszynski wants to merge 1 commit intoClickHouse:mainfrom
marcin-ptaszynski wants to merge 1 commit intoClickHouse:mainfrom
Conversation
marcin-ptaszynski
force-pushed
the
feat-serialize-tuple-struct
branch
2 times, most recently
from
623fa53 to
204210e
Compare
abonander
force-pushed
the
feat-serialize-tuple-struct
branch
from
204210e to
5d3c663
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds support for serializing tuple structs in the SQL serializer by treating them the same way as tuples, wrapping their fields in parentheses and separating them with commas.
Changes:
- Updated
SqlSerializerto useSqlListSerializerfor tuple structs instead ofImpossible - Implemented
SerializeTupleStructtrait forSqlListSerializer - Added test coverage for tuple struct serialization and removed the old test that expected tuple structs to error
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Support for serializing Tuple Structs in the same way as Tuples.
Checklist
Delete items not relevant to your PR: