Handle Variant column NULL values (0xFF discriminator)#400
Draft
thearyanahmed wants to merge 6 commits intoClickHouse:mainfrom
Draft
Handle Variant column NULL values (0xFF discriminator)#400thearyanahmed wants to merge 6 commits intoClickHouse:mainfrom
thearyanahmed wants to merge 6 commits intoClickHouse:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to fix #392 by adding support for NULL values in Variant columns by handling the 0xFF discriminator.
Variant is implicitly nullable — NULL is encoded as discriminator
0xFF, unlikeNullable(T)which uses a separate leading byte. The client now distinguishes between these two null encodings via a genericNullEncodingenum on theSchemaValidator trait, allowingOption<MyEnum>to work with Variant columns.Checklist