Merged
Conversation
serprex
changed the title
serprex
force-pushed
the
more-functions
branch
3 times, most recently
from
eff2587 to
758af35
Compare
serprex
commented
Apr 4, 2026
| 24.3 | window_functions_2.out | ||
| 23 | window_functions_3.out | ||
| 23.8 | window_functions_5.out | ||
| 23.3 | window_functions_3.out |
Member
Author
There was a problem hiding this comment.
do we really need this many versions in CI? 24.3 gets its own entry because it had a typo in new error message ("Aggregate function with name 'lead' does not exists")
Merged
iskakaushik
approved these changes
Apr 4, 2026
Map bool_and/bool_or/every to ClickHouse, fix ranking window pushdown Do not attempt to pushdown the following: string_agg (groupConcat uses incompatible parametric syntax) regr_avgx, regr_avgy, regr_count, regr_intercept, regr_r2, regr_slope, regr_sxx, regr_sxy, regr_syy, json_agg_strict, jsonb_agg_strict These were being pushed down and failing with "Function does not exist" on ClickHouse, now compute correctly on Postgres over rows fetched from the foreign scan Skip frame clause for ranking window functions: row_number, rank, dense_rank, ntile, cume_dist, percent_rank ClickHouse rejects frame specifications on these; FDW was emitting ROWS UNBOUNDED PRECEDING which caused pushdown to fail
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not attempt to pushdown the following:
string_agg (groupConcat uses incompatible parametric syntax)
regr_avgx, regr_avgy, regr_count, regr_intercept, regr_r2, regr_slope,
regr_sxx, regr_sxy, regr_syy, json_agg_strict, jsonb_agg_strict
These were being pushed down and failing with "Function does not exist" on ClickHouse,
now compute correctly on Postgres over rows fetched from the foreign scan
Skip frame clause for ranking window functions:
row_number, rank, dense_rank, ntile, cume_dist, percent_rank
ClickHouse rejects frame specifications on these;
FDW was emitting ROWS UNBOUNDED PRECEDING which caused pushdown to fail
based on #175