chore(proximo): remove proximo service#131
chore(proximo): remove proximo service#131pierrbt wants to merge 17 commits intoClubInfoInsaT:masterfrom
Conversation
I have removed the numver of articles available at proximo. It is still sent by the API but unused in the app
|
@ignyx Keep me up when you have time to review this |
Co-authored-by: ignyx <paul@shimaore.net>
Co-authored-by: ignyx <paul@shimaore.net>
Co-authored-by: ignyx <paul@shimaore.net>
Co-authored-by: ignyx <paul@shimaore.net>
|
@ignyx I need your help. I'm running the app on Windows, and all the errors are caused prettier, saying that CRLF are incorrect. However the .gitattributes files shows that they are supposed to be CRLF. How can I do to pass the tests ? When I'm running lint-fix, it changes all my files to LF, which makes git want to commit 100+ files |
|
I've changed the settings of prettier. Tell me if it's incorrect. Else I think everything looks ok. |
|
Any news about this ? |
|
Sorry, been busy, I've noted to look into it this weekend 👍 Thanks for the changes ! |
|
I perfectly understand, take your time if you have other things planned. |
|
@ignyx Is there any way I can help you for this ? |
|
Hi ! Very sorry for the late. You've probably seen recent activity about the Once we've had a small internal round of testing to make sure the upgrade went well, I'll gladly merge your PRs ! |
|
Yes this looks like a big upgrade ! Congratulations for this and no problem for the delay these are not mandatory prs. Please tell me if you need something from me. |
|
I will check if there is anything other than proximo that is not working any more (or not useful) and can be cleaned up |
|
Hi! Thanks again for the contribution. Could you please:
|
|
|
||
| export type FullDashboardType = { | ||
| today_menu: Array<{ [key: string]: object }>; | ||
| proximo_articles: number; |
Proximo API has been discontinued. I removed all proximo references because they were now useless.
This PR resolves #87
Feel free to comment any error I made.
I created a small script to reset the pinned items on the dashboard if it contained proximo, because else it would display a white square instead of another logo.
Here it is (in fact one of the only thing added) :
As you can see, the Proximo is no longer available.