303 dev change database and cognito to use email to login#321
Open
prooflesben wants to merge 14 commits intomainfrom
Open
303 dev change database and cognito to use email to login#321prooflesben wants to merge 14 commits intomainfrom
prooflesben wants to merge 14 commits intomainfrom
Conversation
…-for-notifications-module' into 303-dev---change-database-and-cognito-to-use-email-to-login
…ged the cognito user pool and changed the dynamo db table, merged in camilas ticket for login and it works with my current example
…tifiaction object so it has userEmail instead of userId
…rson who requested the delete using the id token
…ue to the fact redesigns and refactors are coming
janekamata
reviewed
Feb 18, 2026
Contributor
There was a problem hiding this comment.
After doing some testing everything seems to be working once the Register change is implemented. We might find some more bugs when it comes to frontend Users page once that work is started
The only issue I found
- NotificationPopup.tsx, line 35 references userId
I think you've already fixed the below but noting for documentation here:
- Register has improper username const
- authContext.tsx has numerous username references that should be updated
Collaborator
Author
All of these should be fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes
📝 Description
This ticket is basically the migration from away from using the username in our app. I tried to get it all in one go but most likely I will miss things so I pls urge you to look through the files changed and if you see somewhere that uses the user Id especially in the front end pls request changes. In this pr I also updated our user object to include the newly agreed upon fields of firstName, lastName, and profilePicUrl. The profile pic url is optional since we don't require it upon sign up. I have code to upload a profile pic but that will be a seperate pr since this is already hefty. PLS PLS PLS PLS PLS review this pr fr fr.
Briefly list the changes made to the code:
✔️ Verification
A whole lot of manual testing
Provide screenshots of any new components, styling changes, or pages.
Test Changes
If your new feature required some test to be changed or added to fit the new functionality or changes please document these changes here.
🏕️ (Optional) Future Work / Notes
Didn't change references to user id in the user page related components due to a incoming redesign