forked from Code-4-Community/scaffolding
-
Notifications
You must be signed in to change notification settings - Fork 0
[SSF-111] food manufacturer application frontend #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
amywng
wants to merge
32
commits into
main
Choose a base branch
from
acw/SSF-111-manufacturer-app-frontend
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
ac622e1
fix pantry api body and add manufacturer app backend
amywng 08a983a
make manufacturer attribute optional
amywng c9741df
review comments
amywng dd986b5
fix test name
amywng 14afb2a
add not empty validation to pantry/manufacturer app dtos
amywng b2f494d
fix status everywhere
amywng cc32e62
prettier
amywng 1283213
review comments
amywng 007ce28
Merge branch 'main' into acw/SSF-107-manufacturer-app-backend
amywng 2e5fce7
Merge main
amywng b0d4997
add migration
amywng 6f153a9
fix frontend type
amywng 3ced864
prettier
amywng e123e21
review comments
amywng ab33cf3
fix api docs
amywng 338dd39
switch post endpoint to /application
amywng 3b5579f
review comments
amywng bdf2cb3
Merge branch 'main' into acw/SSF-107-manufacturer-app-backend
amywng 0ad71e6
manufacturer app frontend
amywng 7f1886e
add missing separator
amywng d105bbf
fix api client endpoint
amywng 768ea22
review comments
amywng 2b79d28
add hover blue and fix spacing
amywng f5947c6
Merge branch 'main' into acw/SSF-111-manufacturer-app-frontend
amywng dd24fef
fix api client route
amywng d905cfa
prettier
amywng c58f290
Merge main
amywng 8ef5556
move manufacturer app to public routes section
amywng ced4e18
Merge remote-tracking branch 'origin' into acw/SSF-111-manufacturer-a…
amywng 229a0cf
Merge branch 'main' into acw/SSF-111-manufacturer-app-frontend
amywng fbcfbb3
review comments
amywng f12cf71
somehow missed prettier
amywng File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not suggesting a change, just not super familiar with this pattern - what's the benefit of the action function over calling the submit function from the application component?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think it's better because for separation of concerns, keeping rendering in the component and submission logic in the route action