Add GitHub Actions workflow for Dokku deployments#3
Conversation
| @@ -18,14 +19,13 @@ | |||
| SECRET_KEY = "(@lhxdh^3z1aea9xjny21q^0crno_h48*3!y7en!g#x(5^*zad" | |||
There was a problem hiding this comment.
I know this isn't part of the changes you've made but this whole block is unnecessarily convoluted. It could simply be:
SECRET_KEY = os.getenv('DJANGO_SECRET_KEY', '(@lhxdh^3z1aea9xjny21q^0crno_h48*3!y7en!g#x(5^*zad')
Perhaps we need a separate review of the codebase.
There was a problem hiding this comment.
Also @hanna-tes Please confirm that this isn't the actual secret key used in prod.
There was a problem hiding this comment.
Hi @maquchizi it is the actual secret key i hv it in env but i forgot to remove it here and just use the .getenv 🤭
There was a problem hiding this comment.
Yeah pls do if u have some time kindly review the codebase @VinneyJ @maquchizi i really appreciate that it will help a lot.
There was a problem hiding this comment.
Now that this key has been exposed, let's make sure that it is changed immediately.
…ions - Simplify SECRET_KEY to use os.getenv with empty string fallback - Replace manual image versioning with docker/metadata-action@v6 - Bump dokku/github-action from v1.9.0 to v1.10.0 - Update all GitHub Actions to latest major versions
4 participants
Summary
mainand a manual, environment-gated PROD deploy pathNotes
.github/workflows/deploy.ymldevandprodGitHub Environments should provideDOKKU_HOST,DOKKU_APP_NAME, andDOKKU_SSH_PRIVATE_KEYprodenvironment if approval is desired