-
-
Notifications
You must be signed in to change notification settings - Fork 1
EOL Policy Compliance #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -88,10 +88,21 @@ type ArtifactEntry struct { | |||||
| Size int64 | ||||||
| } | ||||||
|
|
||||||
| // ArtifactStats holds counts by support status | ||||||
| type ArtifactStats struct { | ||||||
| Total int `json:"total"` | ||||||
| Recommended int `json:"recommended"` | ||||||
| Latest int `json:"latest"` | ||||||
| Active int `json:"active"` | ||||||
| Deprecated int `json:"deprecated"` | ||||||
| EOL int `json:"eol"` | ||||||
| } | ||||||
|
|
||||||
| // ArtifactsResult holds paginated results with metadata | ||||||
| type ArtifactsResult struct { | ||||||
| Data []ArtifactEntry | ||||||
| Total int | ||||||
| Stats ArtifactStats | ||||||
| FilteredBy string | ||||||
| } | ||||||
|
|
||||||
|
|
@@ -228,7 +239,7 @@ func (s *ArtifactsService) ProcessGitHubTags(tags []GitHubTag) ArtifactData { | |||||
| } | ||||||
| } | ||||||
|
|
||||||
| // Sort by version number (descending) | ||||||
| // Sort by version number (descending) - highest version first | ||||||
| sort.Slice(artifactTags, func(i, j int) bool { | ||||||
| versionA := s.extractVersionNumber(artifactTags[i].Name) | ||||||
| versionB := s.extractVersionNumber(artifactTags[j].Name) | ||||||
|
|
@@ -237,15 +248,28 @@ func (s *ArtifactsService) ProcessGitHubTags(tags []GitHubTag) ArtifactData { | |||||
|
|
||||||
| now := time.Now().UTC().Format(time.RFC3339) | ||||||
|
|
||||||
| for _, tag := range artifactTags { | ||||||
| for idx, tag := range artifactTags { | ||||||
| versionNumber := s.extractVersionNumber(tag.Name) | ||||||
| version := strconv.Itoa(versionNumber) | ||||||
|
|
||||||
| // Determine support status based on position in sorted list | ||||||
| // Position 0 = Latest (newest single version) | ||||||
| // Position 1-3 = Recommended (stable versions) | ||||||
|
||||||
| // Position 1-3 = Recommended (stable versions) | |
| // Positions 1-3 = Recommended (next 3 stable versions after Latest) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The API documentation comment indicates the default value for includeEol is true, but the actual default has been changed to false on line 40. The documentation should be updated to reflect the new default value.