NW | 25-ITP-Sep | TzeMing Ho | Sprint 2 | book-library-debugging by TzeMingHo · Pull Request #326 · CodeYourFuture/Module-Data-Flows

TzeMingHo · 2025-11-03T18:11:47Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

I have debugged the book library, which now populates the book collection, displays book information correctly, adds books, and deletes books.

cjyuan · 2025-11-12T10:20:11Z

Can you check if any of this general feedback can help you further improve your code?
https://github.com/cjyuan/Module-Data-Flows/blob/book-library-feedback/debugging/book-library/feedback.md

Doing so can help me speed up the review process. Thanks.

TzeMingHo · 2025-11-12T13:29:33Z

Can you check if any of this general feedback can help you further improve your code? https://github.com/cjyuan/Module-Data-Flows/blob/book-library-feedback/debugging/book-library/feedback.md

Doing so can help me speed up the review process. Thanks.

Thank you CJ,

The feedback document is very benefitical. I didn't notice that the project I sumbited still got so many bugs. Thank you for letting me know. I have made some improvements.

A-O-Emmanuel

Your book library works, I just used it and it seems okay, @cjyuan do you have any other comments so that I can mark it complete, thanks

cjyuan

Code works. I just have a few suggestions.

cjyuan · 2025-11-12T20:50:52Z


    <div id="demo" class="collapse">
-      <div class="form-group">
+      <form class="form-group" id="book-form" onsubmit="handleSubmit(event)" >


Could consider attaching event handler to the form in JS (to keep HTML code free of JS code)

Yes. I have removed the function from the HTML and created an eventListener in the script.

cjyuan · 2025-11-12T20:54:05Z

-    pages.value == ""
+    !titleInput.value.trim() ||
+    !authorInput.value.trim() ||
+    pagesInput.value <= 0


Some "weird" numbers (that shouldn't be considered valid page count) could still pass this check. Can you figure out what these numbers are and "handle" them appropriately?

I tried my best to think of the weird numbers could be some spaces before or after the actual numbers. I added a trim process for the pages value as well. I hope this will help prevent some strange situations.

cjyuan · 2025-11-12T20:57:41Z

  } else {
-    let book = new Book(title.value, title.value, pages.value, check.checked);
-    library.push(book);
+    let book = new Book(String(titleInput.value), String(authorInput.value), Number(pagesInput.value), checkInput.checked);


.value is always a string. And on line 39, they could still contain leading or trailing spaces.

cjyuan · 2025-11-12T21:03:01Z

-  for (let n = rowsNumber - 1; n > 0; n-- {
-    table.deleteRow(n);
-  }
+  let tableBody = document.getElementById("display-body")


Could consider (in code refactoring stage) change let to const for all variables that are not going to be reassigned a value.

cjyuan

Changes look great!

cjyuan · 2025-11-13T15:43:26Z

+  let pagesValue = Number(pagesInput.value.trim());
+  let read = checkInput.checked;
  if (
-    !titleInput.value.trim() ||
-    !authorInput.value.trim() ||
-    pagesInput.value <= 0
+    !titleValue||
+    !authorValue ||
+    !Number.isInteger(pagesValue) ||


Trim of pagesinput.value is optional but ensuring pagesValue is an integer would prevent "weird" page count. So, well done!

cjyuan · 2025-11-13T15:50:30Z

+const bookForm = document.getElementById("book-form")
+bookForm.addEventListener("submit", (event) => handleSubmit(event));
+


It is better to group code that is to be executed once (line 52) in one place (to make locating them easier). For example, in the window.onload callback function (lines 3-5).

cjyuan · 2025-11-13T15:57:49Z

    </table>

-    <script src="script.js"></script>
+    <script src="script.js" defer></script>


Suggestion: Consider loading script.js as an ES module to isolate its scope from the global context:

<script src="script.js" type="module"></script>

This ensures that variables, functions, and imports in script.js don’t leak into the global namespace, helps prevent naming conflicts, and enables the use of modern JavaScript features like import and export.

Also, with type="module", defer is automatically enforced.

Thank you. It is something useful. Good to know.

completed book-library debugging

1b926cf

TzeMingHo added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 3, 2025

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 12, 2025

TzeMingHo added 2 commits November 12, 2025 13:06

After reading feedback, some improvement

3ccacab

updated branch name

34fe6f0

TzeMingHo added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 12, 2025

A-O-Emmanuel added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 12, 2025

A-O-Emmanuel reviewed Nov 12, 2025

View reviewed changes

A-O-Emmanuel added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Nov 12, 2025

cjyuan reviewed Nov 12, 2025

View reviewed changes

took the eventhandler off from html, and trim pagesValue

64e5908

TzeMingHo added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 13, 2025

cjyuan reviewed Nov 13, 2025

View reviewed changes

cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 13, 2025

TzeMingHo mentioned this pull request Dec 10, 2025

NW | 25-ITP-Sep | Data flows | TzeMing Ho TzeMingHo/My-Coursework-Planner#42

Open

illicitonion closed this Jan 7, 2026

		const bookForm = document.getElementById("book-form")
		bookForm.addEventListener("submit", (event) => handleSubmit(event));

Uh oh!

Conversation

TzeMingHo commented Nov 3, 2025

Learners, PR Template

Changelist

Uh oh!

cjyuan commented Nov 12, 2025

Uh oh!

TzeMingHo commented Nov 12, 2025

Uh oh!

A-O-Emmanuel left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

cjyuan Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuan Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

A-O-Emmanuel left a comment •

edited

Loading

cjyuan Nov 13, 2025 •

edited

Loading

cjyuan Nov 13, 2025 •

edited

Loading