Birmingham | 25-ITP-Sept | Khor Biel | Sprint 1 | Feature/destructuring#330

Closed

wankoak wants to merge 4 commits intoCodeYourFuture:mainfrom

wankoak:feature/destructuring

wankoak commented Nov 28, 2025 •

edited

Loading

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

I completed
Hogwarts Filter Tasks

Display Gryffindor members.

Display teachers who have pets.

Introduce Yourself Function Update

Updated function parameter to use object destructuring when receiving a person object.

Takeout Receipt Generator

Logged each order item with formatted columns.

Calculated and displayed the total cost using destructured values.

All solutions follow the required formatting and use object destructuring throughout.

No question

wankoak added 4 commits

November 28, 2025 10:45


          Fixed function parameter to use object destructuring

ad2458b


          Fixed function parameter to use object destructuring

004337d


          Completed Hogwarts exercise with destructuring

b07cf4e


          Implemented takeout order receipt with destructuring and formatted to…

8d82196

…tals

github-actions Bot commented Nov 28, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

4 similar comments

github-actions Bot commented Nov 28, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions Bot commented Nov 28, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions Bot commented Nov 28, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions Bot commented Nov 28, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

wankoak changed the title ~~Feature/destructuring~~ Birmingham | 25-ITP-Sept | Khor Biel | Sprint 2 | Feature/destructuring

wankoak added the Needs Review label

github-actions Bot commented Nov 28, 2025

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions Bot removed the Needs Review label

github-actions Bot commented Nov 28, 2025

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

wankoak changed the title ~~Birmingham | 25-ITP-Sept | Khor Biel | Sprint 2 | Feature/destructuring~~ Birmingham | 25-ITP-Sept | Khor Biel | Sprint 1 | Feature/destructuring

wankoak added the Needs Review label

cjyuan reviewed

View reviewed changes

Contributor

cjyuan left a comment

Code looks good.

Sprint-1/destructuring/exercise-2/exercise.js

Comment on lines +76 to +77

		hogwarts.forEach((person) => {
		const { firstName, lastName, house } = person;

Contributor

cjyuan Nov 29, 2025

We could also apply destructuring directly to the parameter as

  hogwarts.forEach(({ firstName, lastName, house }) => {
     ...
  });

Sprint-1/destructuring/exercise-3/exercise.js

		];


		console.log("QTY ITEM TOTAL");

Contributor

cjyuan Nov 29, 2025

Could also use .padStart() and padEnd() to control the spacing in the header; easier to control the spacing than counting space characters.

cjyuan added Complete and removed Needs Review labels

illicitonion closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels