Skip to content

West Midlands | 25-ITP-Sep | Ali Naru | Sprint 2 | feature/BookLibrary #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MohammedNaru wants to merge 6 commits into from
Closed

West Midlands | 25-ITP-Sep | Ali Naru | Sprint 2 | feature/BookLibrary #334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d2fb66a
Refactor book form and submission logic; enhance validation and local…
MohammedNaru Nov 28, 2025
96b6342
Refactor HTML structure and JavaScript logic; improve form handling a…
MohammedNaru Dec 3, 2025
61da010
Update debugging/book-library/index.html
MohammedNaru Dec 3, 2025
25b0dd3
Update debugging/book-library/script.js
MohammedNaru Dec 3, 2025
73aaa68
Merge branch 'main' into Sprint-2
MohammedNaru Dec 4, 2025
e66aa7d
Refactor HTML structure and JavaScript logic; improve form handling, …
MohammedNaru Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 18 additions & 20 deletions debugging/book-library/index.html
View file
Open in desktop
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are errors in the HTML code. Please fix them.

Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
<!DOCTYPE html>
<html>
<html lang="en">
<head>
<title> </title>
<meta
charset="utf-8"
name="viewport"
content="width=device-width, initial-scale=1.0"
/>
<title>My Book Library</title>
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />

<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"></script>
Expand All @@ -31,15 +29,15 @@ <h1>Library</h1>
<div class="form-group">
<label for="title">Title:</label>
<input
type="title"
type="text"
class="form-control"
id="title"
name="title"
required
/>
<label for="author">Author: </label>
<input
type="author"
type="text"
class="form-control"
id="author"
name="author"
Expand All @@ -53,20 +51,20 @@ <h1>Library</h1>
name="pages"
required
/>
<label class="form-check-label">
<div class="form-check-label">
<input
type="checkbox"
class="form-check-input"
id="check"
value=""
/>Read
</label>
<input
type="submit"
value="Submit"
class="btn btn-primary"
onclick="submit();"
/>
/><span>Read</span>
</div>
<button
type="button"
id="submitBtn"
class="btn btn-primary mt-2"
>
Submit
</button>
</div>
</div>

Expand All @@ -93,4 +91,4 @@ <h1>Library</h1>

<script src="script.js"></script>
</body>
</html>
</html>
153 changes: 81 additions & 72 deletions debugging/book-library/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,103 +1,112 @@
let myLibrary = [];

// DOM refs
const titleInput = document.getElementById("title");
const authorInput = document.getElementById("author");
const pagesInput = document.getElementById("pages");
const checkInput = document.getElementById("check");
const submitBtn = document.getElementById("submitBtn");
const table = document.getElementById("display");

window.addEventListener("load", function (e) {
populateStorage();
render();
});

function populateStorage() {
if (myLibrary.length == 0) {
let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
let book2 = new Book(
const book1 = new Book("Robison Crusoe", "Daniel Defoe", 252, true);
const book2 = new Book(
"The Old Man and the Sea",
"Ernest Hemingway",
"127",
127,
true
);
myLibrary.push(book1);
myLibrary.push(book2);
render();
myLibrary.push(book1, book2);
}
}

const title = document.getElementById("title");
const author = document.getElementById("author");
const pages = document.getElementById("pages");
const check = document.getElementById("check");

//check the right input from forms and if its ok -> add the new book (object in array)
//via Book function and start render function
function submit() {
if (
title.value == null ||
title.value == "" ||
pages.value == null ||
pages.value == ""
) {
// wire submit button
submitBtn.addEventListener("click", addBook);

// validate and add book to library
function addBook() {
// trim to avoid spaces-only input
const t = titleInput.value.trim();
const a = authorInput.value.trim();
const pRaw = pagesInput.value.trim();

if (!t || !a || !pRaw) {
alert("Please fill all fields!");
return false;
} else {
let book = new Book(title.value, title.value, pages.value, check.checked);
library.push(book);
render();
return;
}

// pages should be a positive integer (prevent "weird" page counts)
const pNum = Number(pRaw);
if (!Number.isFinite(pNum) || pNum <= 0 || !Number.isInteger(pNum)) {
alert("Please enter a valid positive whole number of pages.");
return;
}

const book = new Book(t, a, pNum, checkInput.checked);
myLibrary.push(book);

// clear inputs and close the collapse
titleInput.value = "";
authorInput.value = "";
pagesInput.value = "";
checkInput.checked = false;

render();
}

function Book(title, author, pages, check) {
// Book constructor
function Book(title, author, pages, read) {
this.title = title;
this.author = author;
this.pages = pages;
this.check = check;
this.read = !!read;
}

// render table rows from myLibrary
function render() {
let table = document.getElementById("display");
let rowsNumber = table.rows.length;
//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {
table.deleteRow(n);
}
//insert updated row and cells
let length = myLibrary.length;
for (let i = 0; i < length; i++) {
let row = table.insertRow(1);
let titleCell = row.insertCell(0);
let authorCell = row.insertCell(1);
let pagesCell = row.insertCell(2);
let wasReadCell = row.insertCell(3);
let deleteCell = row.insertCell(4);
titleCell.innerHTML = myLibrary[i].title;
authorCell.innerHTML = myLibrary[i].author;
pagesCell.innerHTML = myLibrary[i].pages;

//add and wait for action for read/unread button
let changeBut = document.createElement("button");
changeBut.id = i;
changeBut.className = "btn btn-success";
wasReadCell.appendChild(changeBut);
let readStatus = "";
if (myLibrary[i].check == false) {
readStatus = "Yes";
} else {
readStatus = "No";
}
changeBut.innerText = readStatus;

changeBut.addEventListener("click", function () {
myLibrary[i].check = !myLibrary[i].check;
const tbody = table.querySelector("tbody");
tbody.innerHTML = "";

for (let i = 0; i < myLibrary.length; i++) {
const book = myLibrary[i];
const row = tbody.insertRow();

const titleCell = row.insertCell(0);
const authorCell = row.insertCell(1);
const pagesCell = row.insertCell(2);
const wasReadCell = row.insertCell(3);
const deleteCell = row.insertCell(4);

titleCell.textContent = book.title;
authorCell.textContent = book.author;
pagesCell.textContent = book.pages;

// Read toggle button
const changeBut = document.createElement("button");
changeBut.className = "btn btn-sm btn-outline-success";
changeBut.textContent = book.read ? "Yes" : "No";
changeBut.addEventListener("click", function() {
myLibrary[i].read = !myLibrary[i].read;
render();
});
wasReadCell.appendChild(changeBut);

//add delete button to every row and render again
let delButton = document.createElement("button");
delBut.id = i + 5;
deleteCell.appendChild(delBut);
delBut.className = "btn btn-warning";
delBut.innerHTML = "Delete";
delBut.addEventListener("clicks", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);
myLibrary.splice(i, 1);
render();
// Delete button
const delBut = document.createElement("button");
delBut.className = "btn btn-sm btn-warning";
delBut.textContent = "Delete";
delBut.addEventListener("click", function() {
if (confirm(`Delete "${myLibrary[i].title}"?`)) {
myLibrary.splice(i, 1);
render();
}
});
deleteCell.appendChild(delBut);
}
}
}
4 changes: 1 addition & 3 deletions debugging/book-library/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
.form-group {
width: 400px;
height: 300px;
align-self: left;
padding-left: 20px;
}

Expand All @@ -16,4 +14,4 @@

button.btn-info {
margin: 20px;
}
}