Birmingham | 25-ITP-Sept | Khor Biel | Sprint 2 | feature/book-library#337
Closed
wankoak wants to merge 8 commits intoCodeYourFuture:mainfrom
Closed
Birmingham | 25-ITP-Sept | Khor Biel | Sprint 2 | feature/book-library#337wankoak wants to merge 8 commits intoCodeYourFuture:mainfrom
wankoak wants to merge 8 commits intoCodeYourFuture:mainfrom
Conversation
…, and restore full app functionality
…ing for better form readability and alignment
wankoak
added
the
Needs Review
cjyuan
reviewed
Nov 30, 2025
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Can you check if any of this general feedback can help you further improve your code?
https://github.com/cjyuan/Module-Data-Flows/blob/book-library-feedback/debugging/book-library/feedback.md
cjyuan
added
Reviewed
wankoak
added
Needs Review
cjyuan
reviewed
Dec 3, 2025
Contributor
There was a problem hiding this comment.
There are errors in the HTML code.
cjyuan
added
Reviewed
wankoak
added
Needs Review
wankoak
added
Needs Review
cjyuan
reviewed
Dec 3, 2025
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Changes look great. Would be even better if you could also respond to the comments.
|
|
||
| // pages should be a positive integer (prevent "weird" page counts) | ||
| const pNum = Number(pRaw); | ||
| if (!Number.isFinite(pNum) || pNum <= 0 || !Number.isInteger(pNum)) { |
Contributor
There was a problem hiding this comment.
This is solid. The first condition is optional because of this check: !Number.isInteger(pNum).
cjyuan
added
Complete
Author
|
@cjyuan I did respond to the comments and marked them resolved |
Contributor
|
I was referring to written responses. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Here’s a shorter, clean PR description:
Fixed Library App Functionality
What’s Fixed
Other Improvements
No question