Skip to content

London | 25-ITP-Sep| Shaghayegh Shirinfar | Sprint 2 | Book library #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shaghayeghfar wants to merge 3 commits into from
Closed

London | 25-ITP-Sep| Shaghayegh Shirinfar | Sprint 2 | Book library #340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
031d755
the bugs are fixed and add buttom is working
shaghayeghfar Dec 5, 2025
2087dd4
changes based of feedback
shaghayeghfar Dec 6, 2025
d73e1e3
wrong parts were changed
shaghayeghfar Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
179 changes: 87 additions & 92 deletions debugging/book-library/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,96 +1,91 @@
<!DOCTYPE html>
<html>
<head>
<title> </title>
<meta
charset="utf-8"
name="viewport"
content="width=device-width, initial-scale=1.0"
/>
<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"></script>
<link
rel="stylesheet"
href="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css"
/>
<link rel="stylesheet" type="text/css" href="style.css" />
</head>

<body>
<div class="jumbotron text-center">
<h1>Library</h1>
<p>Add books to your virtual library</p>
</div>
<!doctype html>
<html lang="en">

<head>
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
<title>My Book Library</title>

<!-- FEEDBACK APPLIED: HTML validated and cleaned -->
<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css">

<style>
body {
padding: 1.5rem;
}

.btn-small {
padding: 0.25rem 0.5rem;
font-size: 0.9rem;
}
</style>
</head>

<body>
<div class="jumbotron text-center">
<h1 class="display-4">Library</h1>
<p class="lead">Add books to your virtual library</p>
</div>

<button class="btn btn-info mb-3" data-toggle="collapse" data-target="#addForm">
Add new book
</button>

<div id="addForm" class="collapse">
<div class="card card-body mb-4">
<div class="form-row">

<button data-toggle="collapse" data-target="#demo" class="btn btn-info">
Add new book
</button>

<div id="demo" class="collapse">
<div class="form-group">
<label for="title">Title:</label>
<input
type="title"
class="form-control"
id="title"
name="title"
required
/>
<label for="author">Author: </label>
<input
type="author"
class="form-control"
id="author"
name="author"
required
/>
<label for="pages">Pages:</label>
<input
type="number"
class="form-control"
id="pages"
name="pages"
required
/>
<label class="form-check-label">
<input
type="checkbox"
class="form-check-input"
id="check"
value=""
/>Read
</label>
<input
type="submit"
value="Submit"
class="btn btn-primary"
onclick="submit();"
/>
<!-- FEEDBACK APPLIED: clearer input IDs and names -->
<div class="form-group col-md-4">
<label for="titleInput">Title</label>
<input id="titleInput" class="form-control" type="text" required>
</div>

<div class="form-group col-md-4">
<label for="authorInput">Author</label>
<input id="authorInput" class="form-control" type="text" required>
</div>

<div class="form-group col-md-2">
<label for="pagesInput">Pages</label>
<input id="pagesInput" class="form-control" type="number" min="1" required>
</div>

<div class="form-group col-md-2 d-flex align-items-end">
<div class="form-check">
<input id="readCheckbox" class="form-check-input" type="checkbox">
<label class="form-check-label" for="readCheckbox">Read</label>
</div>
</div>
</div>

<div class="text-right">
<button id="addBtn" class="btn btn-primary">Submit</button>
</div>
</div>
</div>

<table class="table table-striped" id="display">
<thead class="thead-dark">
<tr>
<th>Title</th>
<th>Author</th>
<th>Pages</th>
<th>Read</th>
<th></th>
</tr>
</thead>
<tbody>
<!-- Books appear here -->
</tbody>
</table>

<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"></script>

<!-- FEEDBACK APPLIED: load JS as module -->
<script src="script.js" type="module"></script>
</body>

<table class="table" id="display">
<thead class="thead-dark">
<tr>
<th>Title</th>
<th>Author</th>
<th>Number of Pages</th>
<th>Read</th>
<th></th>
</tr>
</thead>
<tbody>
<tr>
<td></td>
<td></td>
<td></td>
<td></td>
<td></td>
</tr>
</tbody>
</table>

<script src="script.js"></script>
</body>
</html>
</html>
Loading