London | 25-ITP-Sep |Sophia Mohamed | Sprint 2 | book library project #342
Closed
saff-coder wants to merge 4 commits intoCodeYourFuture:mainfrom
Closed
London | 25-ITP-Sep |Sophia Mohamed | Sprint 2 | book library project #342saff-coder wants to merge 4 commits intoCodeYourFuture:mainfrom
saff-coder wants to merge 4 commits intoCodeYourFuture:mainfrom
Conversation
saff-coder
added
the
Needs Review
cjyuan
reviewed
Dec 6, 2025
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Can you check if any of this general feedback can help you further improve your code? https://github.com/cjyuan/Module-Data-Flows/blob/book-library-feedback/debugging/book-library/feedback.md
Doing so can help me speed up the review process. Thanks.
cjyuan
added
Reviewed
Trim title and author and reject empty values - Convert page count to a number and validate it is positive
Author
|
Thank you for the feedback! |
saff-coder
added
Needs Review
cjyuan
reviewed
Dec 6, 2025
| return; | ||
| } | ||
|
|
||
| if (!Number.isFinite(pages) || pages <= 0) { |
Contributor
There was a problem hiding this comment.
Should also reject non-integers.
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
I have completed the required tasks and fixed the submit button, and I can add new books
Questions