West Midlands | 25 Sep ITP | Iswat Bello | Sprint 2 | Book library by Iswanna · Pull Request #349 · CodeYourFuture/Module-Data-Flows

Remove placeholder table row <tr> from <tbody> to allow render() to manage all rows

Iswanna

committed

Fix invalid HTML input types by changing <input type="title"/> and <input type="author"/> to type="text"

Iswanna

committed

Switch script.js to type="module", remove inline onclick="submit()", add proper addEventListener on submit button to avoid global scope usage and ensure modern JS practices

Iswanna

committed

Add id="submitBtn" to the submit button to enable attaching an event listener in script.js

Iswanna

committed

Refactor code to remove redundant null checks on input values, ensure page count is stored consistently as a number, and remove unused id attributes from dynamically created buttons

Iswanna

committed

Refactor variable names for clarity: DOM inputs now use descriptive names (titleInput, authorInput, pagesInput, readCheckbox) to avoid confusion with Book object properties

Iswanna

committed

fix(js): add full input validation for author and page count

Iswanna

committed

refactor(js): optimize table clearing using tbody.innerHTML

Iswanna

committed

Clear rows via tbody.innerHTML to preserve header and speed up re-render

Iswanna

committed

ux(delete): confirm before deletion and show non-blocking success alert

Iswanna

committed

Correct book title spelling from “Robison Crusoe” to “Robinson Crusoe” in populateStorage()

Iswanna

committed

Fix(form): prevent default submit to avoid page reload on Submit button click

Iswanna

committed

Chore(html): add lang, split meta tags, set meaningful title, and make Submit a button to pass W3C validation

Iswanna

committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

West Midlands | 25 Sep ITP | Iswat Bello | Sprint 2 | Book library#349

West Midlands | 25 Sep ITP | Iswat Bello | Sprint 2 | Book library#349
Iswanna wants to merge 23 commits intoCodeYourFuture:mainfrom
Iswanna:feature/book-library

Commits on Dec 9, 2025

Fix syntax error in for-loop (line 57) that blocked book list from rendering

Fix: rename delButton to delBut and correct event to 'click' to enable delete action

Rename library to myLibrary in submit() so new books are added to the array

fix: use author.value for author field when creating a new Book (line 40)

fix(render): correct read status display so checked=true shows “Yes” and unchecked shows “No”

Remove redundant render() call in populateStorage (line 19) to avoid double render on load

Commits on Dec 10, 2025

Remove placeholder table row <tr> from <tbody> to allow render() to manage all rows

Fix invalid HTML input types by changing <input type="title"/> and <input type="author"/> to type="text"

Switch script.js to type="module", remove inline onclick="submit()", add proper addEventListener on submit button to avoid global scope usage and ensure modern JS practices

Add id="submitBtn" to the submit button to enable attaching an event listener in script.js

Refactor code to remove redundant null checks on input values, ensure page count is stored consistently as a number, and remove unused id attributes from dynamically created buttons

Refactor variable names for clarity: DOM inputs now use descriptive names (titleInput, authorInput, pagesInput, readCheckbox) to avoid confusion with Book object properties

fix(js): add full input validation for author and page count

refactor(js): optimize table clearing using tbody.innerHTML

Clear rows via tbody.innerHTML to preserve header and speed up re-render

ux(delete): confirm before deletion and show non-blocking success alert

Correct book title spelling from “Robison Crusoe” to “Robinson Crusoe” in populateStorage()

Fix(form): prevent default submit to avoid page reload on Submit button click

Chore(html): add lang, split meta tags, set meaningful title, and make Submit a button to pass W3C validation

Commits on Dec 11, 2025

Add #alerts container and move the dependency scripts to end of the body

Fix indentation inconsistency in index.html

refactor(notices): use #alerts container with CSS-only auto-hide; remove inline styles/timeouts

fix(validation): require pages to be a positive integer