West Midlands | 25-ITP-Sep | Baba Yusuf | Sprint 1 | Feature/destructuring#357
West Midlands | 25-ITP-Sep | Baba Yusuf | Sprint 1 | Feature/destructuring#357Baba05206 wants to merge 3 commits intoCodeYourFuture:mainfrom
Conversation
Baba05206
added
📅 Sprint 1
LonMcGregor
added
the
Review in progress
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
This looks good overall, but I've left some small comments to make it even better
| }, | ||
| ]; | ||
| // Task 1: Gryffindor members | ||
| for (let person of hogwarts) { |
There was a problem hiding this comment.
This works well but you could maybe improve it by trying to use some higher order functions instead of an if inside a for loop. Can you see how you might use these?
There was a problem hiding this comment.
I have now refactored using higher‑order functions (filter + forEach) to remove manual loops and if‑conditions. This makes the logic clearer, more declarative, and easier to extend.
There was a problem hiding this comment.
Are you sure you needed to commit this file? Is the change made directly relevant to the sprint task?
There was a problem hiding this comment.
there was an error that i missed, but I believe this is a relevant task
LonMcGregor
added
Reviewed
Baba05206
added
the
Needs Review
LonMcGregor
added
Complete
3 participants
Learners, PR Template
Self checklist
Changelist
Completed all the tasks as per the readme for exercises 1 - 3 of Sprint 1.
Tested all changes
Questions