Glasgow | 26-ITP-Jan| Martin McLean |Sprint 1|Object Destructuring#388
Closed
mjm-git185 wants to merge 8 commits intoCodeYourFuture:mainfrom
Closed
Glasgow | 26-ITP-Jan| Martin McLean |Sprint 1|Object Destructuring#388mjm-git185 wants to merge 8 commits intoCodeYourFuture:mainfrom
mjm-git185 wants to merge 8 commits intoCodeYourFuture:mainfrom
Conversation
mjm-git185
added
the
Needs Review
codeschris
reviewed
Mar 30, 2026
codeschris
left a comment
codeschris
left a comment
There was a problem hiding this comment.
I have left some comments on areas you need to check on to ensure your code is readable and clean.
|
|
||
| function nameAndHoues(arr){ | ||
| let namesOfGryffindor ="" | ||
| for ( let i =0; i<arr.length; i++){ |
There was a problem hiding this comment.
Check on the indentation of this block right here
| ]; | ||
|
|
||
|
|
||
| function receipt(arr){ |
There was a problem hiding this comment.
The indentation of this code block is not correct.
codeschris
added
Review in progress
mjm-git185
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
mjm-git185
added
the
Needs Review
codeschris
reviewed
Mar 31, 2026
Comment on lines
+16
to
+31
| for(let i=0; i<order.length; i++){ | ||
| const{itemName,quantity,unitPricePence} = arr[i] | ||
|
|
||
|
|
||
| subTotal = unitPricePence * quantity; | ||
| let unitPricePenceAsCash = ( unitPricePence / 100 ) | ||
| unitPricePenceAsCash = unitPricePenceAsCash.toFixed(2) | ||
| totalPrice += subTotal | ||
|
|
||
|
|
||
| totals = quantity + itemName + unitPricePenceAsCash | ||
| // totals = `${quantity} ${itemName} ${unitPricePenceAsCash}` | ||
|
|
||
| console.log("%c",totals, ); | ||
|
|
||
| } |
There was a problem hiding this comment.
The indentation in this code block is not correct.
mjm-git185
added
Needs Review
Author
|
hi Chris i have sorted the indentations is there any thing else needing adressed |
|
All is well now! |
Author
|
thanks for your help |
Author
|
would you mind changing the label to complete when you have a free minute |
codeschris
added
Reviewed
Member
|
Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelist
I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide
my coursework