Skip to content

Glasgow | Jan-26 | Elisabeth Matulian | Sprint 2 |Book library debugging #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Elisabeth-Matulian wants to merge 9 commits into from
Closed

Glasgow | Jan-26 | Elisabeth Matulian | Sprint 2 |Book library debugging #393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
15b2999
fix: add missing bracket in for-loop
Elisabeth-Matulian Mar 31, 2026
a07a2ad
fix: correct variable names, author field, event typo, read status value
Elisabeth-Matulian Apr 1, 2026
2979096
fix: add page title to HTML head
Elisabeth-Matulian Apr 1, 2026
36b570d
fix: meta; input type.
Elisabeth-Matulian Apr 3, 2026
137df51
type added for script
Elisabeth-Matulian Apr 3, 2026
c8f8813
refactoring
Elisabeth-Matulian Apr 3, 2026
e3f16db
removed redundant code; trimmed input value; upd alert message
Elisabeth-Matulian Apr 5, 2026
29b6a86
refactoring: variable declaration; ternary operator; render shortened
Elisabeth-Matulian Apr 5, 2026
2e542ad
refactoring
Elisabeth-Matulian Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions debugging/book-library/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
<!DOCTYPE html>
<html>
<html lang="en">
<head>
<title> </title>
<meta
charset="utf-8"
name="viewport"
content="width=device-width, initial-scale=1.0"
/>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>My Book Library </title>
<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"></script>
Expand All @@ -31,15 +28,15 @@ <h1>Library</h1>
<div class="form-group">
<label for="title">Title:</label>
<input
type="title"
type="text"
class="form-control"
id="title"
name="title"
required
/>
<label for="author">Author: </label>
<input
type="author"
type="text"
class="form-control"
id="author"
name="author"
Expand Down Expand Up @@ -91,6 +88,6 @@ <h1>Library</h1>
</tbody>
</table>

<script src="script.js"></script>
<script src="script.js" type="module"></script>
</body>
</html>
88 changes: 42 additions & 46 deletions debugging/book-library/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,38 +7,43 @@ window.addEventListener("load", function (e) {

function populateStorage() {
if (myLibrary.length == 0) {
let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
let book1 = new Book("Robison Crusoe", "Daniel Defoe", 252, true);
let book2 = new Book(
"The Old Man and the Sea",
"Ernest Hemingway",
"127",
127,
true
);
myLibrary.push(book1);
myLibrary.push(book2);
render();
}
}

const title = document.getElementById("title");
const author = document.getElementById("author");
const pages = document.getElementById("pages");
const inputTitle = document.getElementById("title");
const inputAuthor = document.getElementById("author");
const inputPages = document.getElementById("pages");
const check = document.getElementById("check");

//check the right input from forms and if its ok -> add the new book (object in array)
//via Book function and start render function
function submit() {
const pages = Number(inputPages.value);
const title = inputTitle.value.trim();
const author = inputAuthor.value.trim();

if (
title.value == null ||
title.value == "" ||
pages.value == null ||
pages.value == ""
title == "" ||
author == "" ||
inputPages.value.trim() == "" ||
pages <= 0 ||
pages > 5000 ||
!Number.isInteger(pages)
) {
alert("Please fill all fields!");
alert("Please check your input!");
return false;
} else {
let book = new Book(title.value, title.value, pages.value, check.checked);
library.push(book);
let book = new Book(title, author, pages, check.checked);
myLibrary.push(book);
render();
}
}
Expand All @@ -51,53 +56,44 @@ function Book(title, author, pages, check) {
}

function render() {
let table = document.getElementById("display");
let rowsNumber = table.rows.length;
let tableBody = document.querySelector("#display tbody");
//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {
table.deleteRow(n);
}
tableBody.innerHTML = "";
//insert updated row and cells
let length = myLibrary.length;
for (let i = 0; i < length; i++) {
let row = table.insertRow(1);
let titleCell = row.insertCell(0);
let authorCell = row.insertCell(1);
let pagesCell = row.insertCell(2);
let wasReadCell = row.insertCell(3);
let deleteCell = row.insertCell(4);
titleCell.innerHTML = myLibrary[i].title;
authorCell.innerHTML = myLibrary[i].author;
pagesCell.innerHTML = myLibrary[i].pages;
const row = tableBody.insertRow(0);
const titleCell = row.insertCell(0);
const authorCell = row.insertCell(1);
const pagesCell = row.insertCell(2);
const wasReadCell = row.insertCell(3);
const deleteCell = row.insertCell(4);
titleCell.textContent = myLibrary[i].title;
authorCell.textContent = myLibrary[i].author;
pagesCell.textContent = myLibrary[i].pages;

//add and wait for action for read/unread button
let changeBut = document.createElement("button");
changeBut.id = i;
changeBut.className = "btn btn-success";
wasReadCell.appendChild(changeBut);
let readStatus = "";
if (myLibrary[i].check == false) {
readStatus = "Yes";
} else {
readStatus = "No";
}
changeBut.innerText = readStatus;
const changeBtn = document.createElement("button");
changeBtn.className = "btn btn-success";
wasReadCell.appendChild(changeBtn);
const readStatus = myLibrary[i].check === false ? "No" : "Yes";
changeBtn.innerText = readStatus;

changeBut.addEventListener("click", function () {
changeBtn.addEventListener("click", function () {
myLibrary[i].check = !myLibrary[i].check;
render();
});

//add delete button to every row and render again
let delButton = document.createElement("button");
delBut.id = i + 5;
deleteCell.appendChild(delBut);
delBut.className = "btn btn-warning";
delBut.innerHTML = "Delete";
delBut.addEventListener("clicks", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);
const deleteBtn = document.createElement("button");
deleteCell.appendChild(deleteBtn);
deleteBtn.className = "btn btn-warning";
deleteBtn.innerHTML = "Delete";
deleteBtn.addEventListener("click", function () {
const deletedBook = myLibrary[i].title;
myLibrary.splice(i, 1);
render();
alert(`You've deleted title: ${deletedBook}`);
});
}
}
Loading