Manchester | 26-ITP-Jan | Mehroz Munir | Sprint 1 | Object Destructuring#394
Manchester | 26-ITP-Jan | Mehroz Munir | Sprint 1 | Object Destructuring#394MehrozMunir wants to merge 4 commits into
Conversation
MehrozMunir
added
📅 Sprint 1
Luro91
added
Review in progress
|
|
||
| console.log(...getGryffindorHousePeople(hogwarts)); | ||
|
|
||
| console.log(...findTeachersHavingPets(hogwarts)); |
There was a problem hiding this comment.
The output of the second task does not match the expected output
There was a problem hiding this comment.
Sorry my bad, I did not read the requirement properly that it should be teachers only.
I have pushed the correction. You may review my code now. Thanks.
Luro91
added
Reviewed
MehrozMunir
added
the
Needs Review
Luro91
left a comment
Luro91
left a comment
There was a problem hiding this comment.
Well done. The code works correctly now
A note on commit messages. It's hard to know for me what happens in a commit if the message is not descriptive. A commit should describe what changed in the code. It's also good practice to split commits into logical blocks (for example for each task or each review comment). This makes it easier to understand and additionally the commits could also be undone more easily if needed.
I like this article about commit messages: https://chris.beams.io/git-commit
Luro91
added
Complete
|
Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it. |
3 participants
Self checklist
Changelist
Sprint 1 destructuring exercises completed