Sheffield | 26-ITP-jan | Richard Frimpong | Sprint 1 | Object Destructuring#395
Closed
Richiealx wants to merge 5 commits into
Closed
Sheffield | 26-ITP-jan | Richard Frimpong | Sprint 1 | Object Destructuring#395Richiealx wants to merge 5 commits into
Richiealx wants to merge 5 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
Richiealx
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
Richiealx
changed the title
Richiealx
added
the
Needs Review
Luro91
reviewed
Apr 10, 2026
| total += itemTotal; | ||
|
|
||
| console.log( | ||
| `${itemName} x${quantity} = £${(itemTotal / 100).toFixed(2)}` |
There was a problem hiding this comment.
The output format does not match requirements
There was a problem hiding this comment.
The output is still not the same.
You can use a diff tool to compare your output and the expected results:
QTY ITEM TOTAL
1 Hot cakes 2.32
2 Apple Pie 2.78
1 Egg McMuffin 2.80
1 Sausage McMuffin 3.00
2 Hot Coffee 2.00
4 Hash Brown 1.60
Total: 14.50
QTY ITEM TOTAL
1 Hot Cakes 2.32
2 Apple Pie 2.78
1 Egg McMuffin 2.80
1 Sausage McMuffin 3.00
2 Hot Coffee 2.00
4 Hash Brown 1.60
Total: 14.50
Author
There was a problem hiding this comment.
Thank you for the feedback. I have now adjusted the formatting, spacing, and capitalisation so that the output matches the expected result exactly. I re-ran the file in Node.js and confirmed the output now aligns with the task requirements.
Luro91
added
Reviewed
Author
|
Thank you for the review. I updated the destructuring exercises and fixed Exercise 3 so the output format now matches the task requirements more closely. I also re-tested all three exercises in Node.js. |
Richiealx
added
the
Needs Review
Luro91
removed
the
Needs Review
Richiealx
added
the
Needs Review
Luro91
reviewed
Apr 13, 2026
Luro91
left a comment
Luro91
left a comment
There was a problem hiding this comment.
Well done. The formatting is correctly now
Luro91
added
Complete
Member
|
Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
This PR completes the Object Destructuring exercises for Sprint 1.
All exercises were tested using Node.js and outputs match the expected results.