London | 26-ITP-January | Laura C | Sprint 2 | Book Library

[lauracs24]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

• Fixed issue where books were not displayed on page
• Fixed error when adding a new book to the library
• Corrected author field being incorrectly assigned
• Fixed delete button
• Fixed read status displaying incorrect values
• Improved input validation using trim()
• Cleared form fields after submission to improve user experience

Questions

Are there any further improvements I could make to the structure or readability of this code?

[cjyuan]

Can you also check if any of this general feedback can help you further improve your code?
https://github.com/cjyuan/Module-Data-Flows/blob/book-library-feedback/debugging/book-library/feedback.md

Doing so can help me speed up the review process. Thanks.

[cjyuan]

• Rejecting negative page count is good. Perhaps the alert message should be rephrased accordingly?

• What type of numbers should page count be?

[lauracs24]

I updated validation so page count must be a positive whole number and improved the alert message

[lauracs24]

Thanks for the feedback. I reviewed the general feedback document and applied the relevant improvements
I:

• improved input validation and sanitisation using trim()
• ensured page count is stored and validated as a number
• updated variable names to make it clear they reference DOM elements
• removed unnecessary or duplicate logic
  etc

[cjyuan]

Changes look good. Well done.

[illicitonion]

Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it.