Glasgow | Jan-26 | Elisabeth Matulian | Sprint 3 | Quote generator app#1001
Closed
Elisabeth-Matulian wants to merge 4 commits into
Closed
Glasgow | Jan-26 | Elisabeth Matulian | Sprint 3 | Quote generator app#1001Elisabeth-Matulian wants to merge 4 commits into
Elisabeth-Matulian wants to merge 4 commits into
Conversation
Elisabeth-Matulian
added
the
Needs Review
9 tasks
Comment on lines
+6
to
+7
| const newCodeButton = document.querySelector('#new-quote'); | ||
| function callQuote() { |
There was a problem hiding this comment.
Try to find better names for the const newCodeButton and the function callQuote().
Descriptive names are very useful when debugging
There was a problem hiding this comment.
a name getQuote might be better because all this function does is return a quote, it does not handle anything to do with "display". but this is a nit-pick, looks good otherwise
kyle-tightest
added
Reviewed
Elisabeth-Matulian
added
the
Needs Review
kyle-tightest
added
Complete
Member
|
Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Implement Quote generator app
Questions
N/Q