GLASGOW | Jan-26-ITP | Prakash Dcosta | Sprint 1 | Data Groups by dcostaprakash · Pull Request #1005 · CodeYourFuture/Module-Data-Groups

dcostaprakash · 2026-03-13T22:54:05Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the [style guide]

Changelist

In this PR, i have implemented functions according to requrements and built test cases

Self checklist - [X] I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title - [X] My changes meet the requirements of the task - [X] I have tested my changes - [X] My changes follow the [style guide] ## Changelist In this PR, i have implemented functions according to requrements and built test cases

dcostaprakash · 2026-03-20T15:31:00Z

Made changes as per the review. Thank you

cjyuan · 2026-03-20T16:21:27Z

+  if (numbers.length === 0) return null;
+
+  // Sort numbers without modifying original list
+  const sorted = [...numbers].sort((a, b) => a - b);


Is it necessary to make a copy of numbers before sorting?

No, it is not necessary to make a copy of numbers before sorting, however, it is a good practice.

Can you elaborate how it is a good practice in this scenario?

In this scenario it is not needed. I just tried to make it cleaner by removing non numeric values if any. Do you want me to remove it?

"... to make it cleaner by removing non numeric values" -- You have already removed non numeric values using .filter().

You can keep the code unchanged. I am more interested in knowing why you think "making a copy of numbers before sorting" is a good practice. Can you explain?

Ok. I got your point. According to me, making a copy before sorting is a good practice for the following reasons:

We could accidentally modify it for example if we use the median function directly, the new file would be sorted and it would replace the original file

Incase we need to refer the original file later in the code, we will not be able to since the index of the original file could get sorted
I hope this answers. If i have missed anything, pl add to it. Thank you

By "file", do you mean "array"?

It's true that numbers.sort() can mutate the numbers array. If we need to use numbers after sorting, then it is considered a safe practice to not mutate the array. In your implementation, is numbers being used after sorting?

• Yes by file I meant array.
• No, in my current implementation code, the numbers array is not used again after the sorted variable is created.

"immutability" do has its advantage. The reasons you gave do not quite fit the numbers array as the array is clearly not needed after sorting.

Thought you might be interested in this ChatGPT explaination:
https://chatgpt.com/share/69cf697a-5ea8-8331-bb33-47ccc8b02a17

Ok. I will look at it in detail. Thank you

dcostaprakash · 2026-03-24T16:30:09Z

Have made the changes as per the feedback. Thank you

cjyuan · 2026-03-24T16:44:56Z

Can you address this follow-up comment: #1005 (comment)

Other changes are good.

illicitonion · 2026-05-04T20:23:24Z

Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it.

dcostaprakash added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 13, 2026

cjyuan reviewed Mar 19, 2026

View reviewed changes

Comment thread Sprint-1/fix/median.js

Comment thread Sprint-1/implement/dedupe.test.js

Comment thread Sprint-1/implement/max.test.js Outdated

Comment thread Sprint-1/implement/sum.js Outdated

Comment thread Sprint-1/implement/sum.test.js

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 19, 2026

Changes made as per the review

5d32052

dcostaprakash added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 20, 2026

cjyuan reviewed Mar 20, 2026

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 20, 2026

Made changes as per the review feedback.

3a4e0e0

dcostaprakash added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 24, 2026

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 24, 2026

dcostaprakash added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Apr 2, 2026

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 2, 2026

dcostaprakash added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Apr 3, 2026

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 3, 2026

dcostaprakash added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Apr 3, 2026

cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 3, 2026

cjyuan added the Complete Volunteer to add when work is complete and all review comments have been addressed. label Apr 3, 2026

illicitonion closed this May 4, 2026

Uh oh!

Conversation

dcostaprakash commented Mar 13, 2026

Changelist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dcostaprakash commented Mar 20, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dcostaprakash commented Mar 24, 2026

Uh oh!

cjyuan commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

illicitonion commented May 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cjyuan commented Mar 24, 2026 •

edited

Loading