London|26-ITP-January|Alexandru Pocovnicu|Sprint 3|ToDo List#1013
Closed
alexandru-pocovnicu wants to merge 7 commits intoCodeYourFuture:mainfrom
Closed
London|26-ITP-January|Alexandru Pocovnicu|Sprint 3|ToDo List#1013alexandru-pocovnicu wants to merge 7 commits intoCodeYourFuture:mainfrom
alexandru-pocovnicu wants to merge 7 commits intoCodeYourFuture:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
4 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
alexandru-pocovnicu
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
alexandru-pocovnicu
changed the title
alexandru-pocovnicu
changed the title
alexandru-pocovnicu
added
the
Needs Review
| } | ||
| } | ||
| export function deleteCompleted(todoList){ | ||
| for(let i=todoList.length-1;i>=0;i-- ){ |
There was a problem hiding this comment.
please use a formatter to make your code more readable.
"Prettier" in vscode works well.
| test("remove all completed tasks",()=>{ | ||
| const todoList=createMockTodos() | ||
| Todos.deleteCompleted(todoList) | ||
| expect(todoList).toHaveLength(2) |
There was a problem hiding this comment.
It can help to make your tests more in-depth so that you catch more bugs in your code.
Try validating more fields and testing one more scenario
kyle-tightest
added
Reviewed
Author
|
thank you |
alexandru-pocovnicu
added
Needs Review
kyle-tightest
added
Complete
Member
|
Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
created delete button to delete completed tasks