Sheffield | 26-ITP-jan | Richard Frimpong | Sprint 1 | Data Groups by Richiealx · Pull Request #1032 · CodeYourFuture/Module-Data-Groups

Richiealx · 2026-03-17T21:49:57Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

This pull request contains my completed work for Sprint 1 - Data Groups.

Fix

Completed the fix exercise by correcting the implementation of:

Sprint-1/fix/median.js

Changes made:

fixed the median calculation
handled both odd and even length arrays correctly
filtered out non-numeric values
returned null when no numeric values are present
avoided mutating the original input array

Implement

Completed the implement exercises by implementing the required functions in:

Sprint-1/implement/sum.js
Sprint-1/implement/max.js
Sprint-1/implement/dedupe.js

I also completed the related test files:

Sprint-1/implement/sum.test.js
Sprint-1/implement/max.test.js
Sprint-1/implement/dedupe.test.js

Implemented functionality includes:

sum - calculates the total of numeric values in an array while ignoring non-numeric elements
findMax - returns the largest numeric value in an array while ignoring non-numeric elements
dedupe - removes duplicate values from an array while preserving the first occurrence

Refactor

Completed the refactor exercise by updating:

Sprint-1/refactor/includes.js

Changes made:

replaced the indexed for loop with a for...of loop
simplified the implementation while keeping the same behaviour
confirmed the function still correctly checks whether the target value exists in the array

Testing

All tests were run locally using:

cd Sprint-1
npm test -- fix
npm test -- implement
npm test -- refactor

…groups

…-data-groups

…data-groups

cjyuan

Code is good. I only have a few suggestions.

cjyuan · 2026-03-19T05:50:53Z

+<<<<<<< HEAD
+  // Keep only real numeric values
+  const numbersOnly = list.filter(
+    (item) => typeof item === "number" && !Number.isNaN(item)
+  );
+
+  // Return null if the array contains no numbers
+=======
+  // filter() returns a new array, so this does not modify the original input
+  const numbersOnly = list.filter((item) => Number.isFinite(item));
+
+  // Return null if there are no numeric values
+>>>>>>> a22ed15 (Address mentor feedback for sprint 1 data groups)


This is a unresolved merge conflict. You need to delete the "merge conflict markers" and the code that you do not want to keep.

There are several others on the files in this branch.

Can you fix them?

Thank you for pointing that out.

I have now resolved all merge conflicts by removing the conflict markers and keeping the correct final versions of the code.

I verified that no conflict markers remain, re-ran all Sprint 1 tests, and confirmed everything is passing before pushing the updated changes.

cjyuan · 2026-03-20T03:20:11Z

+test("given an array with no duplicates, it returns a copy of the original array", () => {
+  const input = [1, 2, 3];
+  const result = dedupe(input);

-// Given an array of strings or numbers
+  expect(result).toEqual(input);
+  expect(result).not.toBe(input);
+});


There is a chance both tests on lines 30-31 pass, but result and input have incorrect elements. Can you figure out why?

Thank you. I see the issue now.

I updated the test so it no longer relies on comparing result with input alone. It now checks that:

the returned array has the expected values

the returned array is a different array object

the original input array remains unchanged

I re-ran the implement tests and confirmed everything is passing.

cjyuan · 2026-03-20T14:45:57Z

Changes are all good. Well done.

Richiealx · 2026-03-21T01:20:28Z

@cjyuan Thank you for your guidance!

illicitonion · 2026-05-04T20:22:32Z

Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it.

Richiealx added 6 commits March 13, 2026 20:27

Fix median implementation in sprint 1 fix project

c4b663d

Implement sprint 1 array exercises

4ee9bf8

Refactor includes implementation to use for...of loop

1b6cc9b

Merge branch 'coursework/sprint-1-fix' into coursework/sprint-1-data-…

4d87c5a

…groups

Merge branch 'coursework/sprint-1-implement' into coursework/sprint-1…

074cc7c

…-data-groups

Merge branch 'coursework/sprint-1-refactor' into coursework/sprint-1-…

1f24b43

…data-groups

Richiealx added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 17, 2026

cjyuan reviewed Mar 19, 2026

View reviewed changes

Comment thread Sprint-1/fix/median.js Outdated

Comment thread Sprint-1/implement/dedupe.test.js

Comment thread Sprint-1/implement/max.test.js

Comment thread Sprint-1/implement/sum.test.js

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 19, 2026

Address mentor feedback for sprint 1 data groups

2993b07

Richiealx added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 19, 2026

cjyuan reviewed Mar 19, 2026

View reviewed changes

cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 19, 2026

Resolve sprint 1 merge conflicts and apply mentor feedback

8bd7f4e

Richiealx added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 20, 2026

cjyuan reviewed Mar 20, 2026

View reviewed changes

cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 20, 2026

Improve dedupe test to ensure input is not mutated

bbecf91

Richiealx added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 20, 2026

illicitonion closed this May 4, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Sheffield | 26-ITP-jan | Richard Frimpong | Sprint 1 | Data Groups#1032

Sheffield | 26-ITP-jan | Richard Frimpong | Sprint 1 | Data Groups#1032
Richiealx wants to merge 9 commits intoCodeYourFuture:mainfrom
Richiealx:coursework/sprint-1-data-groups

Richiealx commented Mar 17, 2026

Uh oh!

cjyuan left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cjyuan Mar 19, 2026

Uh oh!

Richiealx Mar 20, 2026

Uh oh!

cjyuan Mar 20, 2026

Uh oh!

Richiealx Mar 20, 2026

Uh oh!

cjyuan commented Mar 20, 2026

Uh oh!

Richiealx commented Mar 21, 2026

Uh oh!

illicitonion commented May 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Richiealx commented Mar 17, 2026

Learners, PR Template

Self checklist

Changelist

Fix

Implement

Refactor

Testing

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cjyuan Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

Richiealx Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Richiealx Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan commented Mar 20, 2026

Uh oh!

Richiealx commented Mar 21, 2026

Uh oh!

illicitonion commented May 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants