West Midlands | 26-Jan-ITP | Fida Ali Zada | Sprint 3 | To-Do List App#1037
Closed
alizada-dev wants to merge 3 commits intoCodeYourFuture:mainfrom
Closed
West Midlands | 26-Jan-ITP | Fida Ali Zada | Sprint 3 | To-Do List App#1037alizada-dev wants to merge 3 commits intoCodeYourFuture:mainfrom
alizada-dev wants to merge 3 commits intoCodeYourFuture:mainfrom
Conversation
alizada-dev
added
the
Needs Review
cjyuan
reviewed
Mar 26, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
-
Code looks good. Well done.
-
Including a short summary of what you've changed or implemented in the Changelist section of the PR description could help reviewers better understand what to expect from this PR.
Comment on lines
+144
to
+151
| const todos = [ | ||
| { task: "", completed: false }, | ||
| { task: "Task 2 description", completed: false }, | ||
| ]; | ||
| const todosBeforeDeletion = [ | ||
| { task: "Task 1 description", completed: false }, | ||
| { task: "Task 2 description", completed: false }, | ||
| ]; |
Contributor
There was a problem hiding this comment.
These two arrays are not identical.
cjyuan
added
Complete
Member
|
Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist